Re: [dpdk-dev] [PATCH v1 6/6] net: fix rte_ether conflicts with libc

2018-01-16 Thread Thomas Monjalon
22/12/2017 15:25, Adrien Mazarguil: > Such a change is unlikely to be accepted for 18.02 in any case, therefore if > the proposed workaround is deemed too risky, I offer to remove this patch > from the series. What do you suggest? Series applied without this patch. Please let's fix it in 18.05.

Re: [dpdk-dev] [PATCH v1 6/6] net: fix rte_ether conflicts with libc

2018-01-16 Thread Olivier Matz
Hi Adrien, On Fri, Dec 22, 2017 at 03:25:27PM +0100, Adrien Mazarguil wrote: > On Fri, Dec 22, 2017 at 02:34:21PM +0100, Olivier MATZ wrote: > > On Thu, Dec 21, 2017 at 02:00:06PM +0100, Adrien Mazarguil wrote: ... > > > +#if defined(__FreeBSD__) > > > +#define addr_bytes octet > > > +#else > >

Re: [dpdk-dev] [PATCH v1 6/6] net: fix rte_ether conflicts with libc

2017-12-22 Thread Adrien Mazarguil
Hi Olivier, On Fri, Dec 22, 2017 at 02:34:21PM +0100, Olivier MATZ wrote: > Hi Adrien, > > On Thu, Dec 21, 2017 at 02:00:06PM +0100, Adrien Mazarguil wrote: > > Applications can't combine either net/ethernet.h or netinet/ether.h > > together with rte_ether.h due to the redefinition of struct ethe

Re: [dpdk-dev] [PATCH v1 6/6] net: fix rte_ether conflicts with libc

2017-12-22 Thread Olivier MATZ
Hi Adrien, On Thu, Dec 21, 2017 at 02:00:06PM +0100, Adrien Mazarguil wrote: > Applications can't combine either net/ethernet.h or netinet/ether.h > together with rte_ether.h due to the redefinition of struct ether_addr and > various macros by the latter. > > This patch adapts rte_ether.h to rely

[dpdk-dev] [PATCH v1 6/6] net: fix rte_ether conflicts with libc

2017-12-21 Thread Adrien Mazarguil
Applications can't combine either net/ethernet.h or netinet/ether.h together with rte_ether.h due to the redefinition of struct ether_addr and various macros by the latter. This patch adapts rte_ether.h to rely on system definitions while maintaining DPDK additions. An unforeseen consequence of i