Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

On Thu, Dec 20, 2018 at 4:58 PM Gavin Hu (Arm Technology China) < gavin...@arm.com> wrote: > > > This change breaks the use of intrinsics in x86 case at least. > > This is true, if intrinsics is still an option for x86 even not is use by > default. > I will fix this in v2. > Please, also check pp

Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

> This change breaks the use of intrinsics in x86 case at least. This is true, if intrinsics is still an option for x86 even not is use by default. I will fix this in v2. Don't know why mail mail client has this issue, I worked with other mail threads correctly.

Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

On Thu, Dec 20, 2018 at 3:36 PM Gavin Hu (Arm Technology China) < gavin...@arm.com> wrote: > >> On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu > wrote: > >> remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the > implementation > >> to the arm specific file, x86 and POWER

Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

>> > On Thu, Dec 20, 2018 at 1:47 PM David Marchand >> > wrote: >> > On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu wrote: >>> remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the implementation >>> to the arm specific file, x86 and P

Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

>> On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu wrote: >> remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the implementation >> to the arm specific file, x86 and POWER have their own implementations. > No, x86 and ppc define their own implementation when _not_ having

Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

On Thu, Dec 20, 2018 at 1:47 PM David Marchand wrote: > On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu wrote: > >> remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the implementation >> to the arm specific file, x86 and POWER have their own implementations. >> > > No, x86 and ppc define their o

Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu wrote: > remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the implementation > to the arm specific file, x86 and POWER have their own implementations. > No, x86 and ppc define their own implementation when _not_ having RTE_FORCE_INTRINSICS. -- Da

[dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file

remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the implementation to the arm specific file, x86 and POWER have their own implementations. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- .../common/include/arch/arm/rte_spin