Re: [dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state

2020-05-06 Thread Ferruh Yigit
On 5/5/2020 8:10 PM, Gaetan Rivet wrote: > The service proxy is initialized at 0. This is assuming that all of > its fields are invalid at 0. The issue is that a file descriptor at 0 is a > valid one. > > The value -1 is used as sentinel during cleanup. Initialize the RX proxy > file descriptor to

Re: [dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state

2020-05-06 Thread Ali Alnubani
Thanks Gaetan. > -Original Message- > From: Gaetan Rivet > Sent: Tuesday, May 5, 2020 10:11 PM > To: dev@dpdk.org > Cc: wangyunj...@huawei.com; Ali Alnubani > Subject: [PATCH v1 3/3] net/failsafe: fix default service proxy state > > The service proxy is initialized at 0. This is assumin

[dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state

2020-05-05 Thread Gaetan Rivet
The service proxy is initialized at 0. This is assuming that all of its fields are invalid at 0. The issue is that a file descriptor at 0 is a valid one. The value -1 is used as sentinel during cleanup. Initialize the RX proxy file descriptor to -1. Fixes: 366226dd859f ("net/failsafe: fix fd leak