Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-29 Thread Honnappa Nagarahalli
> > > > On Wed, Jul 29, 2020 at 4:16 PM Feifei Wang > > wrote: > > > > Are we missing a check in the UT so that dequeued object is what > > > > had been enqueued? Yes, missing for single element enqueue/dequeue > > > > > > > > > > > Dequeue is not necessary to change because the param defined i

Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-29 Thread David Marchand
On Wed, Jul 29, 2020 at 4:16 PM Feifei Wang wrote: > > Are we missing a check in the UT so that dequeued object is what had been > > enqueued? > > > > > Dequeue is not necessary to change because the param defined in > rte_ring_dequeue > is different from that in rte_ring_enqueue: > rte_ring_enqu

Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-29 Thread David Marchand
Hello Feifei, On Wed, Jul 29, 2020 at 8:32 AM Feifei Wang wrote: > > When enqueue one element (object of type void*) to ring in the > performance test, a pointer (the object to be enqueued) should be > passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table > of void *pointers (objects

[dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-28 Thread Feifei Wang
When enqueue one element (object of type void*) to ring in the performance test, a pointer (the object to be enqueued) should be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of void *pointers (objects). Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests