Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-10-28 Thread Stephen Hemminger
From: Burakov, Anatoly > >>>> Sent: Thursday, October 28, 2021 6:30 PM > >>>> To: Xia, Chenbo ; dev@dpdk.org > >>>> Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values > >>>> consistent > >>>> > >&

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-10-28 Thread Burakov, Anatoly
On 28-Oct-21 3:53 PM, Thomas Monjalon wrote: 28/10/2021 13:32, Ferruh Yigit: On 10/28/2021 12:11 PM, Xia, Chenbo wrote: -Original Message- From: Burakov, Anatoly Sent: Thursday, October 28, 2021 6:30 PM To: Xia, Chenbo ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-10-28 Thread Thomas Monjalon
28/10/2021 13:32, Ferruh Yigit: > On 10/28/2021 12:11 PM, Xia, Chenbo wrote: > >> -Original Message- > >> From: Burakov, Anatoly > >> Sent: Thursday, October 28, 2021 6:30 PM > >> To: Xia, Chenbo ; dev@dpdk.org > >> Subject: Re: [dpdk-

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-10-28 Thread Burakov, Anatoly
On 28-Oct-21 12:32 PM, Ferruh Yigit wrote: On 10/28/2021 12:11 PM, Xia, Chenbo wrote: -Original Message- From: Burakov, Anatoly Sent: Thursday, October 28, 2021 6:30 PM To: Xia, Chenbo ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent Hi

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-10-28 Thread Ferruh Yigit
On 10/28/2021 12:11 PM, Xia, Chenbo wrote: -Original Message- From: Burakov, Anatoly Sent: Thursday, October 28, 2021 6:30 PM To: Xia, Chenbo ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent Hi Chenbo, And do we need backport? As 'r

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-10-28 Thread Xia, Chenbo
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, October 28, 2021 6:30 PM > To: Xia, Chenbo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent > > Hi Chenbo, > > > And do we need backport? As '

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-10-28 Thread Burakov, Anatoly
Hi Chenbo, And do we need backport? As 'return -1' does not align with the API doxygen. Thanks, Chenbo Maybe it's the FreeBSD implementation that needs to be adjusted then, because none of those functions are valid on FreeBSD, and the documentation for VFIO functions explicitly mentions that

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-10-28 Thread David Marchand
On Wed, Sep 22, 2021 at 1:31 PM Xia, Chenbo wrote: > > > -Original Message- > > From: Yigit, Ferruh > > Sent: Wednesday, September 22, 2021 5:27 PM > > To: Xia, Chenbo ; Burakov, Anatoly > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-09-22 Thread Xia, Chenbo
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 22, 2021 5:27 PM > To: Xia, Chenbo ; Burakov, Anatoly > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent > > On 9/22/2021 4:30 AM, Xia, Chen

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-09-22 Thread Ferruh Yigit
On 9/22/2021 4:30 AM, Xia, Chenbo wrote: > Hi Anatoly, > >> -Original Message- >> From: dev On Behalf Of Anatoly Burakov >> Sent: Thursday, September 16, 2021 6:37 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return val

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-09-21 Thread Xia, Chenbo
Hi Anatoly, > -Original Message- > From: dev On Behalf Of Anatoly Burakov > Sent: Thursday, September 16, 2021 6:37 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent > > Currently, when VFIO support is not compiled, F

[dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-09-16 Thread Anatoly Burakov
Currently, when VFIO support is not compiled, FreeBSD and Linux have different return values. Fix Linux implementation to follow FreeBSD one. Signed-off-by: Anatoly Burakov --- Notes: Current minimum support Linux kernel is 4.4, and Meson build file sets the RTE_EAL_VFIO config option to