Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-05 Thread Stephen Hemminger
On Fri, 03 Feb 2023 21:49:02 +0100 Thomas Monjalon wrote: > > > > > Good catch. > > > > > By the way, we should remove unused RTE_LOGTYPE_*. > > > > > > > > Yes, for 23.11 would like to work down the list. > > > > > > Do we need to wait 23.11? > > > It is not an ABI breakage. > > > And

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-03 Thread Thomas Monjalon
03/02/2023 21:26, Stephen Hemminger: > On Fri, 03 Feb 2023 21:18:40 +0100 > Thomas Monjalon wrote: > > > 03/02/2023 18:33, Stephen Hemminger: > > > On Fri, 03 Feb 2023 09:42:45 +0100 > > > Thomas Monjalon wrote: > > > > > > > 03/02/2023 01:25, Stephen Hemminger: > > > > > On Wed, 1 Feb 2023

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-03 Thread Stephen Hemminger
On Fri, 03 Feb 2023 21:18:40 +0100 Thomas Monjalon wrote: > 03/02/2023 18:33, Stephen Hemminger: > > On Fri, 03 Feb 2023 09:42:45 +0100 > > Thomas Monjalon wrote: > > > > > 03/02/2023 01:25, Stephen Hemminger: > > > > On Wed, 1 Feb 2023 13:34:41 + > > > > Shivah Shankar Shankar Narayan

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-03 Thread Thomas Monjalon
03/02/2023 18:33, Stephen Hemminger: > On Fri, 03 Feb 2023 09:42:45 +0100 > Thomas Monjalon wrote: > > > 03/02/2023 01:25, Stephen Hemminger: > > > On Wed, 1 Feb 2023 13:34:41 + > > > Shivah Shankar Shankar Narayan Rao wrote: > > > > > > > --- a/lib/eal/include/rte_log.h > > > > +++ b/lib

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-03 Thread Stephen Hemminger
On Fri, 03 Feb 2023 09:42:45 +0100 Thomas Monjalon wrote: > 03/02/2023 01:25, Stephen Hemminger: > > On Wed, 1 Feb 2023 13:34:41 + > > Shivah Shankar Shankar Narayan Rao wrote: > > > > > --- a/lib/eal/include/rte_log.h > > > +++ b/lib/eal/include/rte_log.h > > > @@ -48,6 +48,7 @@ extern "

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-03 Thread Jerin Jacob
On Fri, Feb 3, 2023 at 5:56 AM Stephen Hemminger wrote: > > On Wed, 1 Feb 2023 13:34:41 + > Shivah Shankar Shankar Narayan Rao wrote: > > > +struct rte_ml_dev_info { > > + const char *driver_name; > > + /**< Driver name */ > > + int16_t max_models; > > Why is max_models signed? ot

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-03 Thread Jerin Jacob
On Fri, Feb 3, 2023 at 5:58 AM Stephen Hemminger wrote: > > On Wed, 1 Feb 2023 13:34:41 + > Shivah Shankar Shankar Narayan Rao wrote: > > > +#define RTE_ML_STR_MAX 128 > > +/**< Maximum length of name string */ > > Fixed length strings do create long term technical issues. > But this is big e

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-03 Thread Jerin Jacob
On Fri, Feb 3, 2023 at 5:55 AM Stephen Hemminger wrote: > > On Wed, 1 Feb 2023 13:34:41 + > Shivah Shankar Shankar Narayan Rao wrote: > > > --- a/lib/eal/include/rte_log.h > > +++ b/lib/eal/include/rte_log.h > > @@ -48,6 +48,7 @@ extern "C" { > > #define RTE_LOGTYPE_EFD 18 /**< Log rel

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-03 Thread Thomas Monjalon
03/02/2023 01:25, Stephen Hemminger: > On Wed, 1 Feb 2023 13:34:41 + > Shivah Shankar Shankar Narayan Rao wrote: > > > --- a/lib/eal/include/rte_log.h > > +++ b/lib/eal/include/rte_log.h > > @@ -48,6 +48,7 @@ extern "C" { > > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > >

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-02 Thread Stephen Hemminger
On Wed, 1 Feb 2023 13:34:41 + Shivah Shankar Shankar Narayan Rao wrote: > +#define RTE_ML_STR_MAX 128 > +/**< Maximum length of name string */ Fixed length strings do create long term technical issues. But this is big enough, I doubt it matters. You may want to make sure that string is alwa

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-02 Thread Stephen Hemminger
On Wed, 1 Feb 2023 13:34:41 + Shivah Shankar Shankar Narayan Rao wrote: > +struct rte_ml_dev_info { > + const char *driver_name; > + /**< Driver name */ > + int16_t max_models; Why is max_models signed? other fields are unsigned

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-02 Thread Stephen Hemminger
On Wed, 1 Feb 2023 13:34:41 + Shivah Shankar Shankar Narayan Rao wrote: > --- a/lib/eal/include/rte_log.h > +++ b/lib/eal/include/rte_log.h > @@ -48,6 +48,7 @@ extern "C" { > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to

RE: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-01 Thread Shivah Shankar Shankar Narayan Rao
...@intel.com; Ashwin Sekhar T K ; Pavan Nikhilesh Bhagavatula ; eagost...@nvidia.com; Derek Chickles ; Shivah Shankar Shankar Narayan Rao ; Jerin Jacob Kollanukkaran Subject: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library From: Jerin Jacob Add mldev API

RE: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-01 Thread Shivah Shankar Shankar Narayan Rao
onnappa.nagaraha...@arm.com; > mattias.ronnb...@ericsson.com; ruifeng.w...@arm.com; > d...@linux.vnet.ibm.com; konstantin.anan...@intel.com; > olivier.m...@6wind.com; jay.jayatheert...@intel.com; Ashwin Sekhar T K > ; Pavan Nikhilesh Bhagavatula > ; eagost...@nvidia.com; Derek Chi

[dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2022-11-14 Thread jerinj
From: Jerin Jacob Add mldev API specification to standardize and use the machine learning device and inference operations in vendor neutral way. Following operations are abstracted through APIs - ML device capability probe - ML device configuration - ML device queue pair configuration - ML devi