Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-10-17 Thread Liu, Changpeng
I agree with Maxime, just add an error log doesn't help anything, there might be something wrong in other places, I don't have the context for this issue, if this can be reproduced in SPDK, I suggest to submit an issue to SPDK first. > -Original Message- > From: Xia, Chenbo > Sent: Thur

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-10-14 Thread Li Feng
On Thu, Oct 14, 2021 at 7:38 PM Maxime Coquelin wrote: > > > > On 10/14/21 13:25, Li Feng wrote: > > Thank you for your response. > > > > On Thu, Oct 14, 2021 at 4:17 PM Maxime Coquelin > > wrote: > >> > >> Hi Li, > >> > >> Adding Jin Yu who introduced this function. > >> > >> On 8/27/21 07:12, L

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-10-14 Thread Maxime Coquelin
On 10/14/21 13:25, Li Feng wrote: Thank you for your response. On Thu, Oct 14, 2021 at 4:17 PM Maxime Coquelin wrote: Hi Li, Adding Jin Yu who introduced this function. On 8/27/21 07:12, Li Feng wrote: When getting reqs from the avail ring, the id may exceed inflight queue size. Then th

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-10-14 Thread Li Feng
Thank you for your response. On Thu, Oct 14, 2021 at 4:17 PM Maxime Coquelin wrote: > > Hi Li, > > Adding Jin Yu who introduced this function. > > On 8/27/21 07:12, Li Feng wrote: > > When getting reqs from the avail ring, the id may exceed inflight > > queue size. Then the dpdk will crash foreve

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-10-14 Thread Xia, Chenbo
Hi Changpeng, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, October 14, 2021 4:26 PM > To: Li Feng ; Xia, Chenbo > Cc: dev@dpdk.org > Subject: Re: [PATCH v1] vhost: add sanity check for resubmiting reqs in split > ring > > > > On 10/14/21 10:17, Maxime Coquelin wrote:

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-10-14 Thread Maxime Coquelin
On 10/14/21 10:17, Maxime Coquelin wrote: Hi Li, Adding Jin Yu who introduced this function. Looks like Jin Yu has left Intel, Chenbo, could you find someone from the Intel SPDK team to look at it? On 8/27/21 07:12, Li Feng wrote: When getting reqs from the avail ring, the id may exceed

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-10-14 Thread Maxime Coquelin
Hi Li, Adding Jin Yu who introduced this function. On 8/27/21 07:12, Li Feng wrote: When getting reqs from the avail ring, the id may exceed inflight queue size. Then the dpdk will crash forever. You need to add Fixes tag and Cc sta...@dpdk.org so that it can be backported. Signed-off-by: L

Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-08-31 Thread Li Feng
ping... BTW, how could I retrigger the failure CI? The failure is not about this patch. Thanks, Feng Li Li Feng 于2021年8月27日周五 下午1:16写道: > > When getting reqs from the avail ring, the id may exceed inflight > queue size. Then the dpdk will crash forever. > > Signed-off-by: Li Feng > --- > lib/v

[dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-08-26 Thread Li Feng
When getting reqs from the avail ring, the id may exceed inflight queue size. Then the dpdk will crash forever. Signed-off-by: Li Feng --- lib/vhost/vhost_user.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index 2