Re: [dpdk-dev] [PATCH v1] testpmd: add new command for show port info

2018-08-28 Thread Rami Rosen
Hi, Thanks for this patch, this patch is something needed. It seems to me that adding get_valid_ports() is not necessary, as you have rte_eth_dev_count_avail(), which is implemented the same; please look in rte_ethdev.[c,h; and actually, testpmd uses rte_eth_dev_count_avail(), for example, in atta

Re: [dpdk-dev] [PATCH v1] testpmd: add new command for show port info

2018-08-28 Thread Stephen Hemminger
On Tue, 28 Aug 2018 15:11:34 +0100 Emma Finn wrote: > existing testpmd command "show port info" is too verbose. > Added a new summary command to print brief information on ports. > > Signed-off-by: Emma Finn Looks good. Maybe it would be better to drop off redundant information or only add a s

[dpdk-dev] [PATCH v1] testpmd: add new command for show port info

2018-08-28 Thread Emma Finn
existing testpmd command "show port info" is too verbose. Added a new summary command to print brief information on ports. Signed-off-by: Emma Finn --- app/test-pmd/cmdline.c | 15 ++- app/test-pmd/config.c | 41 + app/test-pmd/testpmd.h | 2