Re: [dpdk-dev] [PATCH v1] net/tap: allow user MAC to be passed as args

2018-03-07 Thread Varghese, Vipin
Hi Ferruh, You are correct about this, I will add initialization send a next version patch. > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, March 6, 2018 4:42 PM > To: Varghese, Vipin ; dev@dpdk.org; > pascal.ma...@6wind.com > Cc: Jain, Deepak K > Subject: Re: [PATCH v1] net/

Re: [dpdk-dev] [PATCH v1] net/tap: allow user MAC to be passed as args

2018-03-06 Thread Ferruh Yigit
On 2/12/2018 2:44 PM, Vipin Varghese wrote: > Allow TAP PMD to pass user desired MAC address as argument. > The argument value is processed as string delimited by ':', > is parsed and converted to HEX MAC address after validation. > > Signed-off-by: Vipin Varghese > Signed-off-by: Pascal Mazon

Re: [dpdk-dev] [PATCH v1] net/tap: allow user MAC to be passed as args

2018-02-22 Thread Pascal Mazon
Acked-by: Pascal Mazon On 12/02/2018 15:44, Vipin Varghese wrote: > Allow TAP PMD to pass user desired MAC address as argument. > The argument value is processed as string delimited by ':', > is parsed and converted to HEX MAC address after validation. > > Signed-off-by: Vipin Varghese > Signe

[dpdk-dev] [PATCH v1] net/tap: allow user MAC to be passed as args

2018-02-12 Thread Vipin Varghese
Allow TAP PMD to pass user desired MAC address as argument. The argument value is processed as string delimited by ':', is parsed and converted to HEX MAC address after validation. Signed-off-by: Vipin Varghese Signed-off-by: Pascal Mazon --- Changes: - seggrated the function for hex sting va

Re: [dpdk-dev] [PATCH v1] net/tap: allow user mac to be passed as args

2017-12-18 Thread Varghese, Vipin
On 11/30/2017 11:49 AM, Vipin Varghese wrote: > One of the uses cases from customer site is use TAP PMD to intake user > specific MAC address during probe. This allows applications make use > of interfaces with desired MAC. > > Extending MAC argumentinfrastructure for tap PMD; we pass custom MAC

Re: [dpdk-dev] [PATCH v1] net/tap: allow user mac to be passed as args

2017-12-08 Thread Pascal Mazon
Hi, Can you also not use a global value for user_mac, but instead change the last argument for eth_dev_tap_create(): Use directly a char mac[ETHER_ADDR_LEN], automatic variable from rte_pmd_tap_probe(). In set_mac_type(), you can check either for "fixed" or a correct custom mac address. Then eth_d

Re: [dpdk-dev] [PATCH v1] net/tap: allow user mac to be passed as args

2017-12-07 Thread Ferruh Yigit
On 11/30/2017 11:49 AM, Vipin Varghese wrote: > One of the uses cases from customer site is use TAP PMD to intake > user specific MAC address during probe. This allows applications > make use of interfaces with desired MAC. > > Extending MAC argumentinfrastructure for tap PMD; we pass custom > MAC

[dpdk-dev] [PATCH v1] net/tap: allow user mac to be passed as args

2017-11-30 Thread Vipin Varghese
One of the uses cases from customer site is use TAP PMD to intake user specific MAC address during probe. This allows applications make use of interfaces with desired MAC. Extending MAC argumentinfrastructure for tap PMD; we pass custom MAC address in string format (sample - 11:22:33:44:55:66). S