Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Paolo Valerio
"Wang, Haiyue" writes: >> -Original Message- >> From: Wang, Haiyue >> Sent: Tuesday, February 2, 2021 20:57 >> To: David Marchand >> Cc: dev ; pvale...@redhat.com; Aaron Conole >> ; Zhang, Qi Z >> ; Rong, Leyi ; Tu, Lijuan >> ; dpdk >> stable ; Guo, Jia ; Richardson, Bruce >> ; >> Ana

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Wang, Haiyue
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, February 2, 2021 20:57 > To: David Marchand > Cc: dev ; pvale...@redhat.com; Aaron Conole > ; Zhang, Qi Z > ; Rong, Leyi ; Tu, Lijuan > ; dpdk > stable ; Guo, Jia ; Richardson, Bruce > ; > Ananyev, Konstantin ; Jerin Jacob Kolla

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Tuesday, February 2, 2021 20:54 > To: Wang, Haiyue > Cc: dev ; pvale...@redhat.com; Aaron Conole > ; Zhang, Qi Z > ; Rong, Leyi ; Tu, Lijuan > ; dpdk > stable ; Guo, Jia ; Richardson, Bruce > ; > Ananyev, Konstantin ; Jerin Jacob Koll

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Tuesday, February 2, 2021 17:45 > To: Wang, Haiyue > Cc: dev ; pvale...@redhat.com; Aaron Conole > ; Zhang, Qi Z > ; Rong, Leyi ; Tu, Lijuan > ; dpdk > stable ; Guo, Jia ; Richardson, Bruce > ; > Ananyev, Konstantin ; Jerin Jacob Koll

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread David Marchand
On Tue, Feb 2, 2021 at 1:42 PM Wang, Haiyue wrote: > > If the driver/hw can't report a valid checksum hint, it should > > announce it does not know if the checksum is valid (neither bad, nor > > good). > > > > So the workaround for udp packets (on this hw model) would be to > > report PKT_RX_L4_CK

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Wang, Haiyue
Hi David, > -Original Message- > From: David Marchand > Sent: Tuesday, February 2, 2021 17:45 > To: Wang, Haiyue > Cc: dev ; pvale...@redhat.com; Aaron Conole > ; Zhang, Qi Z > ; Rong, Leyi ; Tu, Lijuan > ; dpdk > stable ; Guo, Jia ; Richardson, Bruce > ; > Ananyev, Konstantin ; Jerin

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread David Marchand
Hello Haiyue, Thanks for working on it quickly. Cc: ARM maintainers. On Tue, Feb 2, 2021 at 8:23 AM Haiyue Wang wrote: > > There is an 82599 errata that UDP frames with a zero checksum are > incorrectly marked as checksum invalid by the hardware. This was Maybe add a reference to the 82599 hw

[dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-01 Thread Haiyue Wang
There is an 82599 errata that UDP frames with a zero checksum are incorrectly marked as checksum invalid by the hardware. This was leading to misleading PKT_RX_L4_CKSUM_BAD flag. This patch adds a test around this checksum error flag set for this condition. 1. UDP Test sendp(Ether()/IP()/UDP(ch