Re: [dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-07-07 Thread Jie Zhou
On Thu, Jul 01, 2021 at 02:45:24PM -0700, Tyler Retzlaff wrote: > On Fri, Jul 02, 2021 at 12:36:45AM +0300, Dmitry Kozlyuk wrote: > > 2021-07-01 09:21 (UTC-0700), Tyler Retzlaff: > > > On Thu, Jul 01, 2021 at 02:31:29AM +0300, Dmitry Kozlyuk wrote: > > > > Hi Jie, > > > > > > > > 2021-06-23 17:36

Re: [dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-07-01 Thread Tyler Retzlaff
On Fri, Jul 02, 2021 at 12:36:45AM +0300, Dmitry Kozlyuk wrote: > 2021-07-01 09:21 (UTC-0700), Tyler Retzlaff: > > On Thu, Jul 01, 2021 at 02:31:29AM +0300, Dmitry Kozlyuk wrote: > > > Hi Jie, > > > > > > 2021-06-23 17:36 (UTC-0700), Jie Zhou: > > > > From: Jie Zhou > > [...] > > > > + /*

Re: [dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-07-01 Thread Dmitry Kozlyuk
2021-07-01 09:21 (UTC-0700), Tyler Retzlaff: > On Thu, Jul 01, 2021 at 02:31:29AM +0300, Dmitry Kozlyuk wrote: > > Hi Jie, > > > > 2021-06-23 17:36 (UTC-0700), Jie Zhou: > > > From: Jie Zhou > [...] > > > + /* Check if us is valid */ > > > + if (us < 1 || us >(UINT64_MAX - US_PER_S)) { > > >

Re: [dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-07-01 Thread Tyler Retzlaff
On Thu, Jul 01, 2021 at 02:31:29AM +0300, Dmitry Kozlyuk wrote: > Hi Jie, > > 2021-06-23 17:36 (UTC-0700), Jie Zhou: > > From: Jie Zhou > > > > lib/eal alarm APIs rte_eal_alarm_set and rte_eal_alarm_cancel > > on Windows do not check parameters to fail fast for invalid > > parameters, which capt

Re: [dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-06-30 Thread Dmitry Kozlyuk
Hi Jie, 2021-06-23 17:36 (UTC-0700), Jie Zhou: > From: Jie Zhou > > lib/eal alarm APIs rte_eal_alarm_set and rte_eal_alarm_cancel > on Windows do not check parameters to fail fast for invalid > parameters, which captured by DPDK UT alarm_autotest. Please use past tense to describe situation bef

[dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

2021-06-23 Thread Jie Zhou
From: Jie Zhou lib/eal alarm APIs rte_eal_alarm_set and rte_eal_alarm_cancel on Windows do not check parameters to fail fast for invalid parameters, which captured by DPDK UT alarm_autotest. Enforce Windows lib/eal alarm APIs parameters check and log invalid parameter info. Signed-off-by: Jie Z