Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Olivier MATZ
Hi, On Fri, Dec 08, 2017 at 04:04:33PM +0100, Adrien Mazarguil wrote: > On Fri, Dec 08, 2017 at 02:51:15PM +0100, Olivier MATZ wrote: > > On Fri, Dec 08, 2017 at 01:27:26PM +0100, Adrien Mazarguil wrote: > > > On Fri, Dec 08, 2017 at 03:02:44PM +0800, Xueming Li wrote: > > > > Initialize binary re

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Adrien Mazarguil
On Fri, Dec 08, 2017 at 02:51:15PM +0100, Olivier MATZ wrote: > On Fri, Dec 08, 2017 at 01:27:26PM +0100, Adrien Mazarguil wrote: > > On Fri, Dec 08, 2017 at 03:02:44PM +0800, Xueming Li wrote: > > > Initialize binary result memory before parsing to avoid garbage in > > > parsing result. > > > > >

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Xueming(Steven) Li
> -Original Message- > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > Sent: Friday, December 8, 2017 9:51 PM > To: Adrien Mazarguil > Cc: Xueming(Steven) Li ; Wenzhuo Lu > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memor

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Olivier MATZ
On Fri, Dec 08, 2017 at 01:27:26PM +0100, Adrien Mazarguil wrote: > On Fri, Dec 08, 2017 at 03:02:44PM +0800, Xueming Li wrote: > > Initialize binary result memory before parsing to avoid garbage in > > parsing result. > > > > Signed-off-by: Xueming Li > > Since you chose to move the break state

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Adrien Mazarguil
On Fri, Dec 08, 2017 at 03:02:44PM +0800, Xueming Li wrote: > Initialize binary result memory before parsing to avoid garbage in > parsing result. > > Signed-off-by: Xueming Li Since you chose to move the break statement, maybe the original commit mentioned in my previous message (9b3fbb051d2e "

[dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-07 Thread Xueming Li
Initialize binary result memory before parsing to avoid garbage in parsing result. Signed-off-by: Xueming Li --- lib/librte_cmdline/cmdline_parse.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c ind