Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

Hi Ayuj, Akhil, From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Wednesday, April 17, 2019 10:58 AM To: Ayuj Verma ; Trahe, Fiona ; Kusztal, ArkadiuszX Cc: Shally Verma ; Sunila Sahu ; Kanaka Durga Kotamarthy ; Arvind Desai ; dev@dpdk.org Subject: Re: [PATCH v1] fix alphabetical ordering o

Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

Hi Ayuj, > -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.go...@nxp.com; Kusztal, ArkadiuszX > mailto:arkadiuszx.kusz...@intel.com>>; Trahe, > Fiona > mailto:fiona.tr...@intel.com>> > Cc:

Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

Hi Fiona, Sorry for delay in response. Please see inline. Thanks and regards Ayuj Verma From: Trahe, Fiona Sent: 12 April 2019 20:47 To: Ayuj Verma; akhil.go...@nxp.com; Kusztal, ArkadiuszX Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desa

Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

Hi Ayuj, > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > > in rte_crypto.h, which breaks alphabetical order. > > > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. > [Fiona] I presume you tried just swapping the order and it broke? > If something in rte_crypto_asym.h depen

Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

Hi Ayuj, > -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.go...@nxp.com; Kusztal, ArkadiuszX ; > Trahe, Fiona > > Cc: shal...@marvell.com; ss...@marvell.com; kkotamar...@marvell.com; > ade...@marvell.com; > dev@dpdk.

[dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

rte_crypto_sym.h is included prior to rte_crypto_asym.h in rte_crypto.h, which breaks alphabetical order. include rte_crypto_sym.h in rte_crypto_asym.h fixes this. Ayuj Verma (1): lib/crypto: fix alphabetical ordering of headers lib/librte_cryptodev/rte_crypto.h | 1 - lib/librte_cryptod