Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2018-01-18 Thread Pascal Mazon
I have no objection to having the 10G default speed on tap. On 17/01/2018 17:22, Ferruh Yigit wrote: > On 1/17/2018 4:14 PM, Wiles, Keith wrote: >> >>> On Jan 17, 2018, at 10:06 AM, Yigit, Ferruh wrote: >>> >>> On 12/21/2017 1:38 PM, Wiles, Keith wrote: > On Dec 21, 2017, at 10:53 AM, Vi

Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2018-01-17 Thread Ferruh Yigit
On 1/17/2018 4:14 PM, Wiles, Keith wrote: > > >> On Jan 17, 2018, at 10:06 AM, Yigit, Ferruh wrote: >> >> On 12/21/2017 1:38 PM, Wiles, Keith wrote: >>> >>> On Dec 21, 2017, at 10:53 AM, Vipin Varghese wrote: TAP speed is passed as user argument, but never set to interface.

Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2018-01-17 Thread Wiles, Keith
> On Jan 17, 2018, at 10:06 AM, Yigit, Ferruh wrote: > > On 12/21/2017 1:38 PM, Wiles, Keith wrote: >> >> >>> On Dec 21, 2017, at 10:53 AM, Vipin Varghese >>> wrote: >>> >>> TAP speed is passed as user argument, but never set to interface. >>> New logic brings speed get and set to LOCAL an

Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2018-01-17 Thread Ferruh Yigit
On 12/21/2017 1:38 PM, Wiles, Keith wrote: > > >> On Dec 21, 2017, at 10:53 AM, Vipin Varghese >> wrote: >> >> TAP speed is passed as user argument, but never set to interface. >> New logic brings speed get and set to LOCAL and REMOTE interfaces. >> >> Updated the default PMD speeed to 10M as p

Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2017-12-21 Thread Wiles, Keith
> On Dec 21, 2017, at 10:53 AM, Vipin Varghese wrote: > > TAP speed is passed as user argument, but never set to interface. > New logic brings speed get and set to LOCAL and REMOTE interfaces. > > Updated the default PMD speeed to 10M as per Linux Kernel default > value. The problem in settin

[dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2017-12-21 Thread Vipin Varghese
TAP speed is passed as user argument, but never set to interface. New logic brings speed get and set to LOCAL and REMOTE interfaces. Updated the default PMD speeed to 10M as per Linux Kernel default value. Signed-off-by: Vipin Varghese --- drivers/net/tap/rte_eth_tap.c | 185 +++