Re: [dpdk-dev] [PATCH dpdk-dev] net/mlx5: check the reg available for metadata action

2020-05-27 Thread Tonghao Zhang
On Sun, May 24, 2020 at 6:47 PM Tonghao Zhang wrote: > > On Sat, May 23, 2020 at 1:17 AM Slava Ovsiienko > wrote: > > > > Hi, Tonghao Hi maintainers, one question, as doc said: dv_xmeta_en 2, this engages extensive metadata mode, the MARK and META related actions and items operate within all supp

Re: [dpdk-dev] [PATCH dpdk-dev] net/mlx5: check the reg available for metadata action

2020-05-24 Thread Tonghao Zhang
On Sat, May 23, 2020 at 1:17 AM Slava Ovsiienko wrote: > > Hi, Tonghao > > Thank you for the patch. > I suppose, the patch should be extended to encompass the routines: > - flow_dv_convert_action_mark > - flow_dv_convert_action_set_meta (done in the patch) > - flow_dv_validate_item_mark > - flow_d

Re: [dpdk-dev] [PATCH dpdk-dev] net/mlx5: check the reg available for metadata action

2020-05-22 Thread Slava Ovsiienko
Hi, Tonghao Thank you for the patch. I suppose, the patch should be extended to encompass the routines: - flow_dv_convert_action_mark - flow_dv_convert_action_set_meta (done in the patch) - flow_dv_validate_item_mark - flow_dv_validate_item_mark - flow_dv_validate_action_flag - flow_dv_validate_ac

[dpdk-dev] [PATCH dpdk-dev] net/mlx5: check the reg available for metadata action

2020-05-19 Thread xiangxia . m . yue
From: Tonghao Zhang If user don't set the dv_xmeta_en to 1 or 2, in the flow_dv_convert_action_set_meta function: * flow_dv_get_metadata_reg may return the REG_NONE, when MLX5_METADATA_FDB enabled for metadata set action. * reg_to_field(REG_NONE) return MLX5_MODI_OUT_NONE which is invalid.