Re: [dpdk-dev] [PATCH 6/7] examples/vhost: enhance getopt_long usage

2020-12-30 Thread Ibtisam Tariq
Hi, Sorry, for the late reply. We have two solutions: > - we keep this &builtin_net_driver flag use, but we must accept a 0 > return value from getopt_long. > - we convert this option to the same scheme as the other and add a > OPT_BUILTIN_NET_DRIVER_NUM like other options in this example, > What

Re: [dpdk-dev] [PATCH 6/7] examples/vhost: enhance getopt_long usage

2020-12-07 Thread David Marchand
On Tue, Nov 24, 2020 at 1:35 PM Ibtisam Tariq wrote: > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index 8d8c3038b..ce8b64035 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -466,6 +466,33 @@ us_vhost_usage(const char *prgname) >prgname); >

[dpdk-dev] [PATCH 6/7] examples/vhost: enhance getopt_long usage

2020-11-24 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ji

[dpdk-dev] [PATCH 6/7] examples/vhost: enhance getopt_long usage

2020-11-11 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ji