Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-28 Thread Yuanhan Liu
On Tue, Jan 24, 2017 at 11:51:20AM +0100, Olivier MATZ wrote: > On Wed, 18 Jan 2017 13:03:48 +0800, Yuanhan Liu > wrote: > > On Tue, Jan 17, 2017 at 12:18:25PM +0100, Olivier Matz wrote: > > > > I hope I could have time to dig this further, since, honestly, I > > > > don't quite like this patch: i

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-24 Thread Olivier MATZ
On Wed, 18 Jan 2017 13:03:48 +0800, Yuanhan Liu wrote: > On Tue, Jan 17, 2017 at 12:18:25PM +0100, Olivier Matz wrote: > > > I hope I could have time to dig this further, since, honestly, I > > > don't quite like this patch: it makes things un-maintainable. > > > > Well, I'm not that proud of t

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-17 Thread Yuanhan Liu
On Tue, Jan 17, 2017 at 12:18:25PM +0100, Olivier Matz wrote: > > I hope I could have time to dig this further, since, honestly, I don't > > quite like this patch: it makes things un-maintainable. > > Well, I'm not that proud of the patch, but that's the best solution > I've found. Nevertheless sa

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-17 Thread Olivier Matz
Hi Yuanhan, On Mon, 16 Jan 2017 14:48:19 +0800, Yuanhan Liu wrote: > On Mon, Jan 09, 2017 at 06:46:25PM +0100, Olivier Matz wrote: > > The virtio specifications requires that the L4 checksum is set to > > the pseudo header checksum. You can search for "pseudo header" in > > the following doc: > >

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-15 Thread Yuanhan Liu
On Mon, Jan 09, 2017 at 06:46:25PM +0100, Olivier Matz wrote: > The virtio specifications requires that the L4 checksum is set to the > pseudo header checksum. You can search for "pseudo header" in the > following doc: > http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.pdf > > E

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-09 Thread Stephen Hemminger
On Thu, 24 Nov 2016 09:56:38 +0100 Olivier Matz wrote: > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 22d97a4..577c775 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -211,43 +211,73 @@ virtqueue_enqueue_

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-09 Thread Olivier Matz
Hi Yuanhan, On Wed, 14 Dec 2016 15:27:50 +0800, Yuanhan Liu wrote: > Firstly sorry for late response! No problem, I fully understand ;) > On Thu, Nov 24, 2016 at 09:56:38AM +0100, Olivier Matz wrote: > > With virtio, doing tso requires to modify the network > > packet data: > > I thought mor

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2016-12-13 Thread Yuanhan Liu
Hi Olivier, Firstly sorry for late response! On Thu, Nov 24, 2016 at 09:56:38AM +0100, Olivier Matz wrote: > With virtio, doing tso requires to modify the network > packet data: I thought more about it this time, and I'm wondering why it's needed. > - the dpdk API requires to set the l4 checksu

[dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2016-11-24 Thread Olivier Matz
With virtio, doing tso requires to modify the network packet data: - the dpdk API requires to set the l4 checksum to an Intel-Nic-like pseudo header checksum that does not include the ip length - the virtio peer expects that the l4 checksum is a standard pseudo header checksum. This is a pro