Hello,
Thanks for your feedback.
> On Fri, 04 Dec 2020 16:51:09 +0900
> Hideyuki Yamashita wrote:
>
> > +
> > +/* Macros for printing using RTE_LOG */
> > +#define RTE_LOGTYPE_APISTATS RTE_LOGTYPE_USER1
> > +
>
> Please don't use static logtypes.
> Better to allocate a dynamic logtype value and
> Hello,
>
> Thanks for your comments.
> Please see my comments inline tagged with [HY].
>
> > Hi,
> >
> > >
> > > This patch modifies to use apistats by librte_ethdev.
> > >
> > > Signed-off-by: Hideyuki Yamashita
> > > ---
> > > lib/librte_ethdev/meson.build| 6 ++-
> > > lib/librte_ethd
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hideyuki Yamashita
> Sent: Tuesday, December 22, 2020 3:50 AM
>
> Hello,
>
> Thanks for your comments.
> Please see my comments inline tagged with [HY].
>
> > > diff --git a/lib/librte_ethdev/rte_ethdev.h
> b/lib/librte_ethdev/rte_ethdev.h
>
Hello,
Thanks for your comments.
Please see my comments inline tagged with [HY].
> Hi,
>
> >
> > This patch modifies to use apistats by librte_ethdev.
> >
> > Signed-off-by: Hideyuki Yamashita
> > ---
> > lib/librte_ethdev/meson.build| 6 ++-
> > lib/librte_ethdev/rte_apistats.c | 64 ++
Hello,
Thanks for your comments.
Please see my comments inline tagged with [HY].
> Hi,
>
> >
> > This patch modifies to use apistats by librte_ethdev.
> >
> > Signed-off-by: Hideyuki Yamashita
> > ---
> > lib/librte_ethdev/meson.build| 6 ++-
> > lib/librte_ethdev/rte_apistats.c | 64 ++
Hi,
>
> This patch modifies to use apistats by librte_ethdev.
>
> Signed-off-by: Hideyuki Yamashita
> ---
> lib/librte_ethdev/meson.build| 6 ++-
> lib/librte_ethdev/rte_apistats.c | 64
> lib/librte_ethdev/rte_apistats.h | 64 +
On Fri, 04 Dec 2020 16:51:09 +0900
Hideyuki Yamashita wrote:
> +
> +/* Macros for printing using RTE_LOG */
> +#define RTE_LOGTYPE_APISTATS RTE_LOGTYPE_USER1
> +
Please don't use static logtypes.
Better to allocate a dynamic logtype value and use that.
snipped
> +
> +int rte_apistats_init(void)
> +{
> + int i;
> + const struct rte_memzone *mz = NULL;
> + const unsigned int flags = 0;
> +
> + /** Allocate stats in shared memory fo multi process support */
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> + m
This patch modifies to use apistats by librte_ethdev.
Signed-off-by: Hideyuki Yamashita
---
lib/librte_ethdev/meson.build| 6 ++-
lib/librte_ethdev/rte_apistats.c | 64
lib/librte_ethdev/rte_apistats.h | 64
lib/librte_ethdev
9 matches
Mail list logo
