Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Xu, Rosen
Hi, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, October 01, 2019 21:04 > To: dev@dpdk.org > Cc: Kevin Traynor ; Xu, Rosen > ; sta...@dpdk.org > Subject: [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic > > Coverity is complaining about

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Kevin Traynor
November 05, 2019 23:42 >> To: David Marchand ; Xu, Rosen >> >> Cc: dev ; dpdk stable ; Ye, Xiaolong >> >> Subject: Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check >> logic >> >> On 30/10/2019 07:59, David Marchand wrote: >>> He

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Xu, Rosen
Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check > logic > > On 30/10/2019 07:59, David Marchand wrote: > > Hello Rosen, > > > > Review please. > > > > Ping Rosen. > > > On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor > wrote:

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Xu, Rosen
ong > Subject: Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check > logic > > Hello Rosen, > > Review please. > > On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor wrote: > > > > Coverity is complaining about identical code regardless of which > &

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-05 Thread Kevin Traynor
On 30/10/2019 07:59, David Marchand wrote: > Hello Rosen, > > Review please. > Ping Rosen. > On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor wrote: >> >> Coverity is complaining about identical code regardless of which branch >> of the if else is taken. Functionally it means an error will always

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-10-30 Thread David Marchand
Hello Rosen, Review please. On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor wrote: > > Coverity is complaining about identical code regardless of which branch > of the if else is taken. Functionally it means an error will always be > returned if this if else is hit. Remove the else branch. > >

[dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-10-01 Thread Kevin Traynor
Coverity is complaining about identical code regardless of which branch of the if else is taken. Functionally it means an error will always be returned if this if else is hit. Remove the else branch. CID 337928 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)identical_