[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-06 Thread Ravi Kerur
Inline On Mon, Jan 5, 2015 at 12:38 PM, Thomas Monjalon wrote: > 2015-01-05 10:56, Ravi Kerur: > > On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon < > thomas.monjalon at 6wind.com> > > wrote: > > > 2014-12-25 10:33, Ravi Kerur: > > > > Move common functions in eal.c to librte_eal/common directo

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-05 Thread Thomas Monjalon
2015-01-05 10:56, Ravi Kerur: > On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon > wrote: > > 2014-12-25 10:33, Ravi Kerur: > > > Move common functions in eal.c to librte_eal/common directory. > > [...] > > > lib/librte_eal/common/eal_common.c| 328 > > > ++ > >

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-05 Thread Thomas Monjalon
2014-12-25 10:33, Ravi Kerur: > Move common functions in eal.c to librte_eal/common directory. [...] > lib/librte_eal/common/eal_common.c| 328 > ++ > lib/librte_eal/common/eal_externs.h | 42 + I don't agree with these new files. We must try to keep a s

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-05 Thread Ravi Kerur
Inline On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon wrote: > 2014-12-25 10:33, Ravi Kerur: > > Move common functions in eal.c to librte_eal/common directory. > [...] > > lib/librte_eal/common/eal_common.c| 328 > ++ > > lib/librte_eal/common/eal_externs.h

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2015-01-05 Thread Ravi Kerur
Thanks Thomas for the reviews, do you want me to send "v4" version of this patch series or start a different patch series? Thanks, Ravi On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon wrote: > 2014-12-25 10:33, Ravi Kerur: > > Move common functions in eal.c to librte_eal/common directory. > [..

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2014-12-26 Thread Neil Horman
On Thu, Dec 25, 2014 at 11:17:41AM -0800, Ravi Kerur wrote: > Inline > > On Thu, Dec 25, 2014 at 9:44 AM, Neil Horman wrote: > > > On Thu, Dec 25, 2014 at 10:33:14AM -0500, Ravi Kerur wrote: > > > Move common functions in eal.c to librte_eal/common directory. > > > Use RTE_EXEC_ENV_BSDAPP to di

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2014-12-26 Thread Ravi Kerur
On Fri, Dec 26, 2014 at 6:42 AM, Neil Horman wrote: > On Thu, Dec 25, 2014 at 11:17:41AM -0800, Ravi Kerur wrote: > > Inline > > > > On Thu, Dec 25, 2014 at 9:44 AM, Neil Horman > wrote: > > > > > On Thu, Dec 25, 2014 at 10:33:14AM -0500, Ravi Kerur wrote: > > > > Move common functions in eal.c

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2014-12-25 Thread Neil Horman
On Thu, Dec 25, 2014 at 10:33:14AM -0500, Ravi Kerur wrote: > Move common functions in eal.c to librte_eal/common directory. > Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in > common functions. > Makefile changes to reflect new file. > Fix checkpatch warnings and errors. > > Signed-

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2014-12-25 Thread Ravi Kerur
Inline On Thu, Dec 25, 2014 at 9:44 AM, Neil Horman wrote: > On Thu, Dec 25, 2014 at 10:33:14AM -0500, Ravi Kerur wrote: > > Move common functions in eal.c to librte_eal/common directory. > > Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in > > common functions. > > Makefile change

[dpdk-dev] [PATCH 4/7] Move EAL common functions

2014-12-25 Thread Ravi Kerur
Move common functions in eal.c to librte_eal/common directory. Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in common functions. Makefile changes to reflect new file. Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile| 1 + li