Re: [dpdk-dev] [PATCH 4/5] replace snprintf with strlcpy without adding extra include

2019-04-04 Thread Thomas Monjalon
03/04/2019 17:56, Bruce Richardson: > On Wed, Apr 03, 2019 at 08:51:32AM -0700, Stephen Hemminger wrote: > > On Wed, 3 Apr 2019 15:45:04 +0100 > > Bruce Richardson wrote: > > > > > diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c > > > index d215acecc..a542f6f5d 100644 > > >

Re: [dpdk-dev] [PATCH 4/5] replace snprintf with strlcpy without adding extra include

2019-04-03 Thread Bruce Richardson
On Wed, Apr 03, 2019 at 08:51:32AM -0700, Stephen Hemminger wrote: > On Wed, 3 Apr 2019 15:45:04 +0100 > Bruce Richardson wrote: > > > diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c > > index d215acecc..a542f6f5d 100644 > > --- a/lib/librte_ring/rte_ring.c > > +++ b/lib/lib

Re: [dpdk-dev] [PATCH 4/5] replace snprintf with strlcpy without adding extra include

2019-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2019 15:45:04 +0100 Bruce Richardson wrote: > diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c > index d215acecc..a542f6f5d 100644 > --- a/lib/librte_ring/rte_ring.c > +++ b/lib/librte_ring/rte_ring.c > @@ -78,7 +78,7 @@ rte_ring_init(struct rte_ring *r, const c

[dpdk-dev] [PATCH 4/5] replace snprintf with strlcpy without adding extra include

2019-04-03 Thread Bruce Richardson
For files that already have rte_string_fns.h included in them, we can do a straight replacement of snprintf(..."%s",...) with strlcpy. The changes in this patch were auto-generated via command: spatch --sp-file devtools/cocci/strlcpy-with-header.cocci --dir . --in-place Signed-off-by: Bruce Richa