Re: [dpdk-dev] [PATCH 4/5] net/virtio: refactor Tx offload helper

2021-04-08 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Thursday, April 1, 2021 5:53 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; olivier.m...@6wind.com; > f...@sysclose.org; i.maxim...@ovn.org; Chenbo Xia ; > Bruce Richardson ; Konstantin Ananyev > ; jer...@marvell.com; Ruifeng Wan

Re: [dpdk-dev] [PATCH 4/5] net/virtio: refactor Tx offload helper

2021-04-08 Thread Flavio Leitner
On Thu, Apr 01, 2021 at 11:52:42AM +0200, David Marchand wrote: > Purely cosmetic but it is rather odd to have an "offload" helper that > checks if it actually must do something. > We already have the same checks in most callers, so move this branch > in them. > > Signed-off-by: David Marchand >

[dpdk-dev] [PATCH 4/5] net/virtio: refactor Tx offload helper

2021-04-01 Thread David Marchand
Purely cosmetic but it is rather odd to have an "offload" helper that checks if it actually must do something. We already have the same checks in most callers, so move this branch in them. Signed-off-by: David Marchand --- drivers/net/virtio/virtio_rxtx.c | 7 +- drivers/net/virtio/