Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size

2019-10-30 Thread Olivier Matz
On Wed, Oct 30, 2019 at 09:32:08AM +0100, Olivier Matz wrote: > On Tue, Oct 29, 2019 at 06:20:47PM +0100, Olivier Matz wrote: > > On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote: > > > On 10/28/19 5:01 PM, Olivier Matz wrote: > > > > In rte_mempool_populate_default(), we determine

Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size

2019-10-30 Thread Olivier Matz
On Tue, Oct 29, 2019 at 06:20:47PM +0100, Olivier Matz wrote: > On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote: > > On 10/28/19 5:01 PM, Olivier Matz wrote: > > > In rte_mempool_populate_default(), we determine the page size, > > > which is needed for calc_size and allocation of m

Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size

2019-10-29 Thread Olivier Matz
On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote: > On 10/28/19 5:01 PM, Olivier Matz wrote: > > In rte_mempool_populate_default(), we determine the page size, > > which is needed for calc_size and allocation of memory. > > > > Move this in a function and export it, it will be used

Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size

2019-10-29 Thread Andrew Rybchenko
On 10/28/19 5:01 PM, Olivier Matz wrote: In rte_mempool_populate_default(), we determine the page size, which is needed for calc_size and allocation of memory. Move this in a function and export it, it will be used in next commit. Signed-off-by: Olivier Matz One question below: Reviewed-by:

[dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size

2019-10-28 Thread Olivier Matz
In rte_mempool_populate_default(), we determine the page size, which is needed for calc_size and allocation of memory. Move this in a function and export it, it will be used in next commit. Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 51 ++ l