Re: [dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8

2021-01-13 Thread Ruifeng Wang
> -Original Message- > From: Medvedkin, Vladimir > Sent: Thursday, January 14, 2021 2:52 AM > To: Ruifeng Wang ; Bruce Richardson > > Cc: dev@dpdk.org; nd ; jer...@marvell.com; > d...@linux.vnet.ibm.com; Honnappa Nagarahalli > > Subject: Re: [PATCH 4/4] test/lpm: improve coverage on tbl

Re: [dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8

2021-01-13 Thread Medvedkin, Vladimir
Hi Ruifeng, Please find comment inlined. Apart from that looks good. On 08/01/2021 08:21, Ruifeng Wang wrote: Existing test cases create 256 tbl8 groups for testing. The number covers only 8 bit next_hop/group field. Since the next_hop/group field had been extended to 24-bits, creating more tha

Re: [dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8

2021-01-11 Thread David Christensen
On 1/8/21 12:21 AM, Ruifeng Wang wrote: Existing test cases create 256 tbl8 groups for testing. The number covers only 8 bit next_hop/group field. Since the next_hop/group field had been extended to 24-bits, creating more than 256 groups in tests can improve the coverage. Coverage was not exp

[dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8

2021-01-08 Thread Ruifeng Wang
Existing test cases create 256 tbl8 groups for testing. The number covers only 8 bit next_hop/group field. Since the next_hop/group field had been extended to 24-bits, creating more than 256 groups in tests can improve the coverage. Coverage was not expanded to reach the max supported group number