Re: [dpdk-dev] [PATCH 4/4] net: replace ifdefs with runtime branches

2019-07-08 Thread David Christensen
01/07/2019 22:41, Bruce Richardson: On Mon, Jul 01, 2019 at 09:30:02PM +0200, Thomas Monjalon wrote: 29/05/2019 17:41, Bruce Richardson: Use the flag checking functions and a couple of empty stubs to remove the ifdefs from the middle of the C code, and replace them with more readable regular

Re: [dpdk-dev] [PATCH 4/4] net: replace ifdefs with runtime branches

2019-07-04 Thread Thomas Monjalon
01/07/2019 22:41, Bruce Richardson: > On Mon, Jul 01, 2019 at 09:30:02PM +0200, Thomas Monjalon wrote: > > 29/05/2019 17:41, Bruce Richardson: > > > Use the flag checking functions and a couple of empty stubs to remove the > > > ifdefs from the middle of the C code, and replace them with more reada

Re: [dpdk-dev] [PATCH 4/4] net: replace ifdefs with runtime branches

2019-07-01 Thread Bruce Richardson
On Mon, Jul 01, 2019 at 09:30:02PM +0200, Thomas Monjalon wrote: > 29/05/2019 17:41, Bruce Richardson: > > Use the flag checking functions and a couple of empty stubs to remove the > > ifdefs from the middle of the C code, and replace them with more readable > > regular if statements. Other ifdefs

Re: [dpdk-dev] [PATCH 4/4] net: replace ifdefs with runtime branches

2019-07-01 Thread Thomas Monjalon
29/05/2019 17:41, Bruce Richardson: > Use the flag checking functions and a couple of empty stubs to remove the > ifdefs from the middle of the C code, and replace them with more readable > regular if statements. Other ifdefs at the top of the file are kept, but > are not mixed with C code, so ther

[dpdk-dev] [PATCH 4/4] net: replace ifdefs with runtime branches

2019-05-29 Thread Bruce Richardson
Use the flag checking functions and a couple of empty stubs to remove the ifdefs from the middle of the C code, and replace them with more readable regular if statements. Other ifdefs at the top of the file are kept, but are not mixed with C code, so there is a clean separation. Signed-off-by: Bru