Re: [dpdk-dev] [PATCH 4/4] net/virtio: improve offload check performance

2018-06-05 Thread Tiwei Bie
On Tue, Jun 05, 2018 at 01:58:00PM +0200, Maxime Coquelin wrote: > On 06/05/2018 01:20 PM, Tiwei Bie wrote: > > On Tue, Jun 05, 2018 at 11:43:11AM +0200, Maxime Coquelin wrote: > > > On 06/05/2018 05:10 AM, Tiwei Bie wrote: > > > > On Mon, Jun 04, 2018 at 04:29:56PM +0200, Maxime Coquelin wrote: >

Re: [dpdk-dev] [PATCH 4/4] net/virtio: improve offload check performance

2018-06-05 Thread Maxime Coquelin
On 06/05/2018 01:20 PM, Tiwei Bie wrote: On Tue, Jun 05, 2018 at 11:43:11AM +0200, Maxime Coquelin wrote: On 06/05/2018 05:10 AM, Tiwei Bie wrote: On Mon, Jun 04, 2018 at 04:29:56PM +0200, Maxime Coquelin wrote: On 06/04/2018 01:55 PM, Tiwei Bie wrote: On Fri, Jun 01, 2018 at 02:47:58PM +0

Re: [dpdk-dev] [PATCH 4/4] net/virtio: improve offload check performance

2018-06-05 Thread Tiwei Bie
On Tue, Jun 05, 2018 at 11:43:11AM +0200, Maxime Coquelin wrote: > On 06/05/2018 05:10 AM, Tiwei Bie wrote: > > On Mon, Jun 04, 2018 at 04:29:56PM +0200, Maxime Coquelin wrote: > > > On 06/04/2018 01:55 PM, Tiwei Bie wrote: > > > > On Fri, Jun 01, 2018 at 02:47:58PM +0200, Maxime Coquelin wrote: >

Re: [dpdk-dev] [PATCH 4/4] net/virtio: improve offload check performance

2018-06-05 Thread Maxime Coquelin
On 06/05/2018 05:10 AM, Tiwei Bie wrote: On Mon, Jun 04, 2018 at 04:29:56PM +0200, Maxime Coquelin wrote: On 06/04/2018 01:55 PM, Tiwei Bie wrote: On Fri, Jun 01, 2018 at 02:47:58PM +0200, Maxime Coquelin wrote: [...] @@ -253,13 +246,15 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, st

Re: [dpdk-dev] [PATCH 4/4] net/virtio: improve offload check performance

2018-06-04 Thread Tiwei Bie
On Mon, Jun 04, 2018 at 04:29:56PM +0200, Maxime Coquelin wrote: > On 06/04/2018 01:55 PM, Tiwei Bie wrote: > > On Fri, Jun 01, 2018 at 02:47:58PM +0200, Maxime Coquelin wrote: [...] > > > @@ -253,13 +246,15 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, > > > struct rte_mbuf *cookie, > > >

Re: [dpdk-dev] [PATCH 4/4] net/virtio: improve offload check performance

2018-06-04 Thread Maxime Coquelin
On 06/04/2018 01:55 PM, Tiwei Bie wrote: On Fri, Jun 01, 2018 at 02:47:58PM +0200, Maxime Coquelin wrote: Instead of checking the multiple Virtio features bits for every packet, let's do the check once at configure time and store it in virtio_hw struct. Signed-off-by: Maxime Coquelin ---

Re: [dpdk-dev] [PATCH 4/4] net/virtio: improve offload check performance

2018-06-04 Thread Tiwei Bie
On Fri, Jun 01, 2018 at 02:47:58PM +0200, Maxime Coquelin wrote: > Instead of checking the multiple Virtio features bits for > every packet, let's do the check once at configure time and > store it in virtio_hw struct. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH 4/4] net/virtio: improve offload check performance

2018-06-01 Thread Maxime Coquelin
Instead of checking the multiple Virtio features bits for every packet, let's do the check once at configure time and store it in virtio_hw struct. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 19 +++ drivers/net/virtio/virtio_pci.h| 2 ++ drivers/