Re: [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-11-05 Thread Kevin Traynor
On 30/10/2019 16:27, Ajit Khaparde wrote: > On Wed, Oct 30, 2019 at 12:43 AM David Marchand > wrote: > >> Hello Ajit, Kevin, >> >> On Wed, Oct 2, 2019 at 3:29 AM Ajit Khaparde >> wrote: >>> >>> On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor >> wrote: >>> If rc contains a non-zero return code

Re: [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-10-30 Thread Ajit Khaparde
On Wed, Oct 30, 2019 at 12:43 AM David Marchand wrote: > Hello Ajit, Kevin, > > On Wed, Oct 2, 2019 at 3:29 AM Ajit Khaparde > wrote: > > > > On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor > wrote: > > > > > If rc contains a non-zero return code from bnxt_hwrm_send_message(), > > > HWRM_CHECK_RES

Re: [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-10-30 Thread David Marchand
Hello Ajit, Kevin, On Wed, Oct 2, 2019 at 3:29 AM Ajit Khaparde wrote: > > On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor wrote: > > > If rc contains a non-zero return code from bnxt_hwrm_send_message(), > > HWRM_CHECK_RESULT_SILENT() will return. > > > > Just after that code, there is an 'if (!rc

Re: [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-10-01 Thread Ajit Khaparde
On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor wrote: > If rc contains a non-zero return code from bnxt_hwrm_send_message(), > HWRM_CHECK_RESULT_SILENT() will return. > > Just after that code, there is an 'if (!rc) {...} else {...}'. > Coverity is complaining that this if else statement is dead cod

[dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-10-01 Thread Kevin Traynor
If rc contains a non-zero return code from bnxt_hwrm_send_message(), HWRM_CHECK_RESULT_SILENT() will return. Just after that code, there is an 'if (!rc) {...} else {...}'. Coverity is complaining that this if else statement is dead code as rc will always be 0 if that code is reached. 4309