Re: [dpdk-dev] [PATCH 3/8] crypto/octeontx: add asymmetric session operations

2019-10-02 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 1, 2019 6:27 PM > To: Anoob Joseph ; Pablo de Lara > > Cc: Kanaka Durga Kotamarthy ; Jerin Jacob > Kollanukkaran ; Narayana Prasad Raju Athreya > ; Fiona Trahe ; Shally Verma >

Re: [dpdk-dev] [PATCH 3/8] crypto/octeontx: add asymmetric session operations

2019-10-01 Thread Akhil Goyal
Hi Anoob, Just a couple of nits > + > +static __rte_always_inline void > +cpt_modex_param_normalize(uint8_t **data, size_t *len) > +{ > + size_t i; > + > + /* Strip leading NUL bytes */ Typo NULL > + > + for (i = 0; i < *len; i++) { > + if ((*data)[i] != 0) > +

[dpdk-dev] [PATCH 3/8] crypto/octeontx: add asymmetric session operations

2019-09-09 Thread Anoob Joseph
From: Kanaka Durga Kotamarthy Add asymmetric session setup and free functions Signed-off-by: Anoob Joseph Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Sunila Sahu --- drivers/common/cpt/cpt_mcode_defines.h | 9 ++ drivers/common/cpt/cpt_ucode_asym.h | 169