Re: [dpdk-dev] [PATCH 3/3] net/mlx5: remove flags setting from flow preparation

2018-11-04 Thread Yongseok Koh
On Sun, Nov 04, 2018 at 01:29:13AM -0700, Ori Kam wrote: > > > > -Original Message- > > From: dev On Behalf Of Yongseok Koh > > Sent: Friday, November 2, 2018 11:08 PM > > To: Shahaf Shuler > > Cc: dev@dpdk.org; Yongseok Koh > > Subject: [dp

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: remove flags setting from flow preparation

2018-11-04 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Yongseok Koh > Sent: Friday, November 2, 2018 11:08 PM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh > Subject: [dpdk-dev] [PATCH 3/3] net/mlx5: remove flags setting from flow > preparation > > Even thou

[dpdk-dev] [PATCH 3/3] net/mlx5: remove flags setting from flow preparation

2018-11-02 Thread Yongseok Koh
Even though flow_drv_prepare() takes item_flags and action_flags to be filled in, those are not used and will be overwritten by parsing of flow_drv_translate(). There's no reason to keep the flags and fill it. Appropriate notes are added to the documentation of flow_drv_prepare() and flow_drv_trans