Re: [dpdk-dev] [PATCH 26/28] net/virtio: use eal I/O device memory read/write API

2016-12-15 Thread Yuanhan Liu
On Wed, Dec 14, 2016 at 09:45:34PM -0800, Santosh Shukla wrote: > On Wed, Dec 14, 2016 at 11:02:23AM +0800, Yuanhan Liu wrote: > > On Wed, Dec 14, 2016 at 07:25:56AM +0530, Jerin Jacob wrote: > > > * Following macros are derived from linux/pci_regs.h, however, > > > * we can't simply include th

Re: [dpdk-dev] [PATCH 26/28] net/virtio: use eal I/O device memory read/write API

2016-12-14 Thread Santosh Shukla
On Wed, Dec 14, 2016 at 11:02:23AM +0800, Yuanhan Liu wrote: > On Wed, Dec 14, 2016 at 07:25:56AM +0530, Jerin Jacob wrote: > > * Following macros are derived from linux/pci_regs.h, however, > > * we can't simply include that header here, as there is no such > > @@ -320,37 +322,37 @@ static con

Re: [dpdk-dev] [PATCH 26/28] net/virtio: use eal I/O device memory read/write API

2016-12-13 Thread Yuanhan Liu
On Wed, Dec 14, 2016 at 07:25:56AM +0530, Jerin Jacob wrote: > * Following macros are derived from linux/pci_regs.h, however, > * we can't simply include that header here, as there is no such > @@ -320,37 +322,37 @@ static const struct virtio_pci_ops legacy_ops = { > static inline uint8_t > i

Re: [dpdk-dev] [PATCH 26/28] net/virtio: use eal I/O device memory read/write API

2016-12-13 Thread Yuanhan Liu
On Wed, Dec 14, 2016 at 07:25:56AM +0530, Jerin Jacob wrote: > From: Santosh Shukla > > Replace the raw I/O device memory read/write access with eal > abstraction for I/O device memory read/write access to fix > portability issues across different architectures. I think these APIs are good: Ack

[dpdk-dev] [PATCH 26/28] net/virtio: use eal I/O device memory read/write API

2016-12-13 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob CC: Huawei Xie CC: Yuanhan Liu --- drivers