Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-09-11 Thread Ananyev, Konstantin
Hi Jiayu, > > > Linux supports two kinds of IP identifier: fixed identifier and > > > incremental > > identifier, and > > > which one to use depends on upper protocol modules. Specifically, if the > > protocol module > > > wants fixed identifiers, it will set SKB_GSO_TCP_FIXEDID to skb->gso_type,

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-09-04 Thread Hu, Jiayu
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, September 4, 2017 5:55 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, > Jianfeng > Subject: RE: [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support > > Hi Jiayu, > > > -Original Message- >

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-09-04 Thread Ananyev, Konstantin
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Monday, September 4, 2017 4:32 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, Jianfeng > > Subject: Re: [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support > > Hi Konstantin, > > About the IP identifier, I ch

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-09-03 Thread Jiayu Hu
Hi Konstantin, About the IP identifier, I check the linux codes and have some feedbacks inline. On Wed, Aug 30, 2017 at 09:38:33AM +0800, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Hu, Jiayu > > Sent: Thursday, August 24, 2017 3:16 PM > > To: dev@dpdk.org > > Cc: Ka

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Kavanagh, Mark B
--- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin >> Sent: Wednesday, August 30, 2017 10:39 AM >> To: Kavanagh, Mark B ; Hu, Jiayu > >> Cc: dev@dpdk.org; Tan, Jianfeng >> Subject: Re: [dpdk-dev] [PATCH 2/5] gso/lib: add

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Wednesday, August 30, 2017 10:39 AM > To: Kavanagh, Mark B ; Hu, Jiayu > > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: Re: [dpdk-dev] [PATCH 2/5] gso/lib: add

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Ananyev, Konstantin
Hi Mark, > >> > + > >> > +void > >> > +gso_parse_packet(struct rte_mbuf *pkt) > >> > >> There is a function rte_net_get_ptype() that supposed to provide similar > >functionality. > >> So we probably don't need to create a new SW parse function here, instead > >would be better > >> to reuse (and up

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Kavanagh, Mark B
>From: Hu, Jiayu >Sent: Wednesday, August 30, 2017 3:56 AM >To: Ananyev, Konstantin >Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, Jianfeng > >Subject: Re: [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support > >Hi Konstantin, > >Thanks for your important suggestions. My feedbacks are inline. > >On Wed, Aug

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-30 Thread Jiayu Hu
Hi Konstantin, On Wed, Aug 30, 2017 at 09:38:33AM +0800, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Hu, Jiayu > > Sent: Thursday, August 24, 2017 3:16 PM > > To: dev@dpdk.org > > Cc: Kavanagh, Mark B ; Ananyev, Konstantin > > ; Tan, Jianfeng > > ; Hu, Jiayu > > Sub

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-29 Thread Jiayu Hu
Hi Konstantin, Thanks for your important suggestions. My feedbacks are inline. On Wed, Aug 30, 2017 at 09:38:33AM +0800, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Hu, Jiayu > > Sent: Thursday, August 24, 2017 3:16 PM > > To: dev@dpdk.org > > Cc: Kavanagh, Mark B ;

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-29 Thread Ananyev, Konstantin
> -Original Message- > From: Hu, Jiayu > Sent: Thursday, August 24, 2017 3:16 PM > To: dev@dpdk.org > Cc: Kavanagh, Mark B ; Ananyev, Konstantin > ; Tan, Jianfeng > ; Hu, Jiayu > Subject: [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support > > This patch adds GSO support for TCP/IPv4 packets

[dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-24 Thread Jiayu Hu
This patch adds GSO support for TCP/IPv4 packets. Supported packets may include a single VLAN tag. TCP/IPv4 GSO assumes that all input packets have correct checksums, and doesn't update checksums for output packets (the responsibility for this lies with the application). Additionally, TCP/IPv4 GSO