Re: [dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread Bruce Richardson
On Thu, Mar 07, 2019 at 01:42:36PM +0100, David Marchand wrote: >On Thu, Mar 7, 2019 at 1:37 PM David Marchand ><[1]david.march...@redhat.com> wrote: > >On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson ><[2]bruce.richard...@intel.com> wrote: > > Since we have the version numb

Re: [dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread Bruce Richardson
On Thu, Mar 07, 2019 at 01:37:08PM +0100, David Marchand wrote: >On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > Since we have the version number in a separate file at the root > level, > we should not need to duplicate this in rt

Re: [dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread David Marchand
On Thu, Mar 7, 2019 at 1:37 PM David Marchand wrote: > > > On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson < > bruce.richard...@intel.com> wrote: > >> Since we have the version number in a separate file at the root level, >> we should not need to duplicate this in rte_version.h too. Best >> appr

Re: [dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread David Marchand
On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson wrote: > Since we have the version number in a separate file at the root level, > we should not need to duplicate this in rte_version.h too. Best > approach here is to move the macros for specifying the year/month/etc. > parts from the version head

[dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread Bruce Richardson
Since we have the version number in a separate file at the root level, we should not need to duplicate this in rte_version.h too. Best approach here is to move the macros for specifying the year/month/etc. parts from the version header file to the build config file - leaving the other utility macro