[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Yuanhan Liu
On Fri, Sep 09, 2016 at 02:24:20PM +0800, Tan, Jianfeng wrote: > > > On 9/9/2016 2:03 PM, Yuanhan Liu wrote: > >>GET_PROTOCOL_FEATURES > >>is not supported yet. I see those features in PROTOCOL_FEATURES is for live > >>migration (right?). > >Not exactly. PROTOCOL_FEATURES was firstly introduced w

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Tan, Jianfeng
On 9/9/2016 2:03 PM, Yuanhan Liu wrote: >> GET_PROTOCOL_FEATURES >> is not supported yet. I see those features in PROTOCOL_FEATURES is for live >> migration (right?). > Not exactly. PROTOCOL_FEATURES was firstly introduced while MQ was > enabled. Thus it's no wonder MQ is the first protocol featu

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Yuanhan Liu
On Fri, Sep 09, 2016 at 01:50:16PM +0800, Tan, Jianfeng wrote: > On 9/9/2016 12:19 PM, Yuanhan Liu wrote: > > >> > >> > >> Never mind, above fix on the vhost side will not take effect on > >> existing > >> vpp-vhost implementations. > >> > >> Actually, I was talking about the

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Tan, Jianfeng
On 9/9/2016 12:19 PM, Yuanhan Liu wrote: >> >> >> Never mind, above fix on the vhost side will not take effect on >> existing >> vpp-vhost implementations. >> >> Actually, I was talking about the DPDK vhost implementation :) >> >> >> This patch is talking about vpp's native

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Yuanhan Liu
On Fri, Sep 09, 2016 at 11:59:18AM +0800, Tan, Jianfeng wrote: > It's actually a good catch. After a light thought, I think in > DPDK vhost, we > may need to create those virtqueues once unix socket gets > connected, just > like in vhost-net, virtqu

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Tan, Jianfeng
On 9/8/2016 8:18 PM, Yuanhan Liu wrote: > On Thu, Sep 08, 2016 at 04:53:22PM +0800, Tan, Jianfeng wrote: >> >> On 9/6/2016 4:20 PM, Yuanhan Liu wrote: >>> On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: Hi Yuanhan, On 9/6/2016 2:42 PM, Yuanhan Liu wrote: > O

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2016 at 04:53:22PM +0800, Tan, Jianfeng wrote: > > > On 9/6/2016 4:20 PM, Yuanhan Liu wrote: > >On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: > >>Hi Yuanhan, > >> > >> > >>On 9/6/2016 2:42 PM, Yuanhan Liu wrote: > >>>On Fri, Aug 05, 2016 at 11:36:42AM +, Jianf

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-08 Thread Tan, Jianfeng
On 9/6/2016 4:20 PM, Yuanhan Liu wrote: > On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: >> Hi Yuanhan, >> >> >> On 9/6/2016 2:42 PM, Yuanhan Liu wrote: >>> On Fri, Aug 05, 2016 at 11:36:42AM +, Jianfeng Tan wrote: When virtio_user is used with VPP's native vhost user, it

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-06 Thread Yuanhan Liu
On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: > Hi Yuanhan, > > > On 9/6/2016 2:42 PM, Yuanhan Liu wrote: > >On Fri, Aug 05, 2016 at 11:36:42AM +, Jianfeng Tan wrote: > >>When virtio_user is used with VPP's native vhost user, it cannot > >>send/receive any packets. > >> > >>T

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-06 Thread Tan, Jianfeng
Hi Yuanhan, On 9/6/2016 2:42 PM, Yuanhan Liu wrote: > On Fri, Aug 05, 2016 at 11:36:42AM +, Jianfeng Tan wrote: >> When virtio_user is used with VPP's native vhost user, it cannot >> send/receive any packets. >> >> The root cause is that vpp-vhost-user translates the message >> VHOST_USER_SET

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-06 Thread Yuanhan Liu
On Fri, Aug 05, 2016 at 11:36:42AM +, Jianfeng Tan wrote: > When virtio_user is used with VPP's native vhost user, it cannot > send/receive any packets. > > The root cause is that vpp-vhost-user translates the message > VHOST_USER_SET_FEATURES as puting this device into init state, > aka, zero

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-08-08 Thread Tan, Jianfeng
[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of > messages > > On Fri, 5 Aug 2016 11:36:42 + > Jianfeng Tan wrote: > > > When virtio_user is used with VPP's native vhost user, it cannot > > send/receive any packets. > > >

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-08-05 Thread Jianfeng Tan
When virtio_user is used with VPP's native vhost user, it cannot send/receive any packets. The root cause is that vpp-vhost-user translates the message VHOST_USER_SET_FEATURES as puting this device into init state, aka, zero all related structures. However, previous code puts this message at last

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-08-05 Thread Stephen Hemminger
On Fri, 5 Aug 2016 11:36:42 + Jianfeng Tan wrote: > When virtio_user is used with VPP's native vhost user, it cannot > send/receive any packets. > > The root cause is that vpp-vhost-user translates the message > VHOST_USER_SET_FEATURES as puting this device into init state, > aka, zero all