Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Olivier Matz
On Thu, Jan 18, 2018 at 11:48:09PM +0800, Tiwei Bie wrote: > On Thu, Jan 18, 2018 at 03:55:53PM +0100, Olivier Matz wrote: > > On Thu, Jan 18, 2018 at 10:05:49PM +0800, Tiwei Bie wrote: > > > On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > > > > Rationalize the function virtio_dev_f

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Tiwei Bie
On Thu, Jan 18, 2018 at 03:55:53PM +0100, Olivier Matz wrote: > On Thu, Jan 18, 2018 at 10:05:49PM +0800, Tiwei Bie wrote: > > On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > > > Rationalize the function virtio_dev_free_mbufs(): > > > > > > - skip NULL vqs instead of crashing: this

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Olivier Matz
On Thu, Jan 18, 2018 at 10:05:49PM +0800, Tiwei Bie wrote: > On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > > Rationalize the function virtio_dev_free_mbufs(): > > > > - skip NULL vqs instead of crashing: this is required for the > > next commit > > - use the same kind of loop t

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Tiwei Bie
On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > Rationalize the function virtio_dev_free_mbufs(): > > - skip NULL vqs instead of crashing: this is required for the > next commit > - use the same kind of loop than in virtio_free_queues() > - also flush mbufs from the control queue

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 02:55:44PM +0100, Olivier Matz wrote: > On Thu, Jan 18, 2018 at 09:26:09PM +0800, Yuanhan Liu wrote: > > Hi Oliver, > > > > On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > > > Rationalize the function virtio_dev_free_mbufs(): > > > > > > - skip NULL vqs ins

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Olivier Matz
On Thu, Jan 18, 2018 at 09:26:09PM +0800, Yuanhan Liu wrote: > Hi Oliver, > > On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > > Rationalize the function virtio_dev_free_mbufs(): > > > > - skip NULL vqs instead of crashing: this is required for the > > next commit > > - use the s

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Yuanhan Liu
Hi Oliver, On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > Rationalize the function virtio_dev_free_mbufs(): > > - skip NULL vqs instead of crashing: this is required for the > next commit > - use the same kind of loop than in virtio_free_queues() > - also flush mbufs from the c

[dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Olivier Matz
Rationalize the function virtio_dev_free_mbufs(): - skip NULL vqs instead of crashing: this is required for the next commit - use the same kind of loop than in virtio_free_queues() - also flush mbufs from the control queue (this is useless yet) - factorize common code between rxq, txq, cq Cc: s