Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Thomas Monjalon
26/10/2017 15:16, Akhil Goyal: > On 10/26/2017 6:37 PM, Thomas Monjalon wrote: > > 26/10/2017 14:59, Akhil Goyal: > >> Hi Thomas, > >> > >> On 10/26/2017 6:03 PM, Thomas Monjalon wrote: > >>> 26/10/2017 14:28, Radu Nicolau: > > On 10/26/2017 12:39 PM, Thomas Monjalon wrote: > > 26/10/

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Akhil Goyal
On 10/26/2017 6:37 PM, Thomas Monjalon wrote: 26/10/2017 14:59, Akhil Goyal: Hi Thomas, On 10/26/2017 6:03 PM, Thomas Monjalon wrote: 26/10/2017 14:28, Radu Nicolau: On 10/26/2017 12:39 PM, Thomas Monjalon wrote: 26/10/2017 13:27, David Marchand: On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicol

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Thomas Monjalon
26/10/2017 14:59, Akhil Goyal: > Hi Thomas, > > On 10/26/2017 6:03 PM, Thomas Monjalon wrote: > > 26/10/2017 14:28, Radu Nicolau: > >> > >> On 10/26/2017 12:39 PM, Thomas Monjalon wrote: > >>> 26/10/2017 13:27, David Marchand: > On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau > wrote: >

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Akhil Goyal
Hi Thomas, On 10/26/2017 6:03 PM, Thomas Monjalon wrote: 26/10/2017 14:28, Radu Nicolau: On 10/26/2017 12:39 PM, Thomas Monjalon wrote: 26/10/2017 13:27, David Marchand: On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: On 10/26/2017 11:36 AM, David Marchand wrote: On Thu, Oct 26, 2017

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Thomas Monjalon
26/10/2017 14:28, Radu Nicolau: > > On 10/26/2017 12:39 PM, Thomas Monjalon wrote: > > 26/10/2017 13:27, David Marchand: > >> On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau > >> wrote: > >>> On 10/26/2017 11:36 AM, David Marchand wrote: > On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau > >>>

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Ananyev, Konstantin
> -Original Message- > From: David Marchand [mailto:david.march...@6wind.com] > Sent: Thursday, October 26, 2017 12:39 PM > To: Ananyev, Konstantin > Cc: Nicolau, Radu ; dev@dpdk.org; Doherty, Declan > ; De Lara Guarch, Pablo > ; Hemant Agrawal ; > bor...@mellanox.com; avia...@mellanox

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Radu Nicolau
On 10/26/2017 12:39 PM, David Marchand wrote: On Thu, Oct 26, 2017 at 1:30 PM, Ananyev, Konstantin wrote: -Original Message- From: Nicolau, Radu It can be disabled in the code, but as far as I know there is a general push back against having conditionally compiled code. I originally h

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Radu Nicolau
On 10/26/2017 12:39 PM, Thomas Monjalon wrote: 26/10/2017 13:27, David Marchand: On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: On 10/26/2017 11:36 AM, David Marchand wrote: On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau wrote: --- a/drivers/net/ixgbe/Makefile +++ b/drivers/net/ixgbe

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Thomas Monjalon
26/10/2017 13:27, David Marchand: > On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: > > On 10/26/2017 11:36 AM, David Marchand wrote: > >> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau > >> wrote: > >>> --- a/drivers/net/ixgbe/Makefile > >>> +++ b/drivers/net/ixgbe/Makefile > >>> +ifneq ($(

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread David Marchand
On Thu, Oct 26, 2017 at 1:30 PM, Ananyev, Konstantin wrote: >> -Original Message- >> From: Nicolau, Radu >> It can be disabled in the code, but as far as I know there is a general >> push back against having conditionally compiled code. I originally had >> the security sections in ixgbe PM

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Ananyev, Konstantin
> -Original Message- > From: Nicolau, Radu > Sent: Thursday, October 26, 2017 12:01 PM > To: David Marchand > Cc: dev@dpdk.org; Doherty, Declan ; De Lara Guarch, > Pablo ; Hemant > Agrawal ; bor...@mellanox.com; avia...@mellanox.com; > Thomas Monjalon ; > sandeep.ma...@nxp.com; Jerin J

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread David Marchand
On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: > On 10/26/2017 11:36 AM, David Marchand wrote: >> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau >> wrote: >>> >>> Build fails when rte_security is disabled; make rte_security mandatory >>> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec"

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Radu Nicolau
On 10/26/2017 11:36 AM, David Marchand wrote: On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau wrote: Build fails when rte_security is disabled; make rte_security mandatory Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/Makefile | 6

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread David Marchand
On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau wrote: > Build fails when rte_security is disabled; make rte_security mandatory > Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") > > Signed-off-by: Radu Nicolau > --- > drivers/net/ixgbe/Makefile | 6 ++ > 1 file changed, 6 insertions(+)

[dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

2017-10-26 Thread Radu Nicolau
Build fails when rte_security is disabled; make rte_security mandatory Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefi