Re: [dpdk-dev] [PATCH 2/2] vhost: only drop vqs with built-in virtio_net.c driver

2018-02-01 Thread Maxime Coquelin
On 02/01/2018 11:24 AM, Stefan Hajnoczi wrote: On Wed, Jan 31, 2018 at 07:07:50PM +0100, Maxime Coquelin wrote: Hi Stefan, On 01/31/2018 06:46 PM, Stefan Hajnoczi wrote: Commit e29109323595beb3884da58126ebb3b878cb66f5 ("vhost: destroy unused virtqueues when multiqueue not negotiated") broke

Re: [dpdk-dev] [PATCH 2/2] vhost: only drop vqs with built-in virtio_net.c driver

2018-01-31 Thread Maxime Coquelin
Hi Stefan, On 01/31/2018 06:46 PM, Stefan Hajnoczi wrote: Commit e29109323595beb3884da58126ebb3b878cb66f5 ("vhost: destroy unused virtqueues when multiqueue not negotiated") broke vhost-scsi by removing virtqueues when the virtio-net-specific VIRTIO_NET_F_MQ feature bit is missing. The vhost_us

[dpdk-dev] [PATCH 2/2] vhost: only drop vqs with built-in virtio_net.c driver

2018-01-31 Thread Stefan Hajnoczi
Commit e29109323595beb3884da58126ebb3b878cb66f5 ("vhost: destroy unused virtqueues when multiqueue not negotiated") broke vhost-scsi by removing virtqueues when the virtio-net-specific VIRTIO_NET_F_MQ feature bit is missing. The vhost_user.c code shouldn't assume all devices are vhost net device b