Re: [dpdk-dev] [PATCH 2/2] net/tap: add buffer overflow checks before checksum

2018-12-20 Thread Wiles, Keith
> On Dec 17, 2018, at 9:50 AM, Richardson, Bruce > wrote: > > The checksum calculation APIs take only the packet headers pointers as > parameters, so they assume that the lengths reported in those headers are > correct. However, a malicious packet could claim to be far larger than it > is, so

Re: [dpdk-dev] [PATCH 2/2] net/tap: add buffer overflow checks before checksum

2018-12-20 Thread Ferruh Yigit
On 12/17/2018 3:50 PM, Bruce Richardson wrote: > The checksum calculation APIs take only the packet headers pointers as > parameters, so they assume that the lengths reported in those headers are > correct. However, a malicious packet could claim to be far larger than it > is, so we need to check t

[dpdk-dev] [PATCH 2/2] net/tap: add buffer overflow checks before checksum

2018-12-17 Thread Bruce Richardson
The checksum calculation APIs take only the packet headers pointers as parameters, so they assume that the lengths reported in those headers are correct. However, a malicious packet could claim to be far larger than it is, so we need to check the header lengths in the driver before calling the chec