Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix crash in dev_info_get in secondary process

2019-07-31 Thread Stephen Hemminger
On Wed, 31 Jul 2019 07:36:26 + Raslan Darawsheh wrote: > Hi Stephen, > > Can you please confirm that Slava's patch fixed your issue and this patch is > not needed anymore for MLX5? > So that I can take mlx4 patch only from this series? > > Kindest regards, > Raslan Darawsheh OK, but my ot

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix crash in dev_info_get in secondary process

2019-07-31 Thread Raslan Darawsheh
; Sent: Friday, July 12, 2019 11:54 PM > To: Matan Azrad ; Shahaf Shuler > ; Yongseok Koh ; Slava > Ovsiienko > Cc: dev@dpdk.org; s...@paloaltonetworks.com; Stephen Hemminger > > Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix crash in dev_info_get in > secondary process > >

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix crash in dev_info_get in secondary process

2019-07-15 Thread Slava Ovsiienko
Hi, Stephen >mlx5_get_ifname uses priv->ctx which is not a valid pointer in a secondary >process. 1. Sorry, mlx5_priv structure does not contain ctx field. Do you mean priv->sh (shared context) ? This one is allocated with rte_zmalloc(), that supposes shared memory allocation and shared cont

[dpdk-dev] [PATCH 2/2] net/mlx5: fix crash in dev_info_get in secondary process

2019-07-12 Thread Stephen Hemminger
mlx5_dev_info_get calls mlx5_get_ifname, but mlx5_get_ifname uses priv->ctx which is not a valid pointer in a secondary process. The fix is to cache the value in primary. In the primary process, get and store the interface index of the device so that secondary process can see it. Fixes: e60fbd5b2