Re: [dpdk-dev] [PATCH 2/2] mlx5: don't depend on kernel version

2018-01-02 Thread Nelio Laranjeiro
Hi Stephen, Please see few comments bellow, On Tue, Jan 02, 2018 at 12:53:10PM -0800, Stephen Hemminger wrote: > This driver uses ethtool to get link status. The ethtool API has new > and old deprecated API. Rather than checking kernel version, use the > same algorithm that the ethtool command do

[dpdk-dev] [PATCH 2/2] mlx5: don't depend on kernel version

2018-01-02 Thread Stephen Hemminger
This driver uses ethtool to get link status. The ethtool API has new and old deprecated API. Rather than checking kernel version, use the same algorithm that the ethtool command does; check the new API first and if that fails, try the old one. Also, use common code for getting link state up/down a