Re: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure

2018-11-19 Thread Zhang, Roy Fan
Hi Konstantin, Thanks for the review. Comments inline. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, November 16, 2018 2:32 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH 2/2] cryptodev: change

Re: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure

2018-11-16 Thread Ananyev, Konstantin
Hi Fan, > > This patch changes the symmetric session structure of cryptodev. > The symmetric session now contains extra information for secure > access purposes. The patch also includes the updates to the > PMDs, test applications, and examples to fit the change. Few more comments from me in-lin

Re: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure

2018-11-15 Thread Ananyev, Konstantin
Hi Fan, > - > /** Cryptodev symmetric crypto session > * Each session is derived from a fixed xform chain. Therefore each session > * has a fixed algo, key, op-type, digest_len etc. > */ > struct rte_cryptodev_sym_session { > - __extension__ void *sess_private_data[0]; > - /**< Pri

[dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure

2018-11-15 Thread Fan Zhang
This patch changes the symmetric session structure of cryptodev. The symmetric session now contains extra information for secure access purposes. The patch also includes the updates to the PMDs, test applications, and examples to fit the change. Signed-off-by: Fan Zhang --- app/test-crypto-perf/