Re: [dpdk-dev] [PATCH 11/21] net/ixgbe/base: modify loop accounting for retries

2020-06-29 Thread Sun, GuinanX
Hi Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Monday, June 22, 2020 8:00 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Cramer, Jeb J > Subject: Re: [dpdk-dev] [PATCH 11/21] net/ixgbe/base: modify loop accounting > for retries > > On 6/12/202

Re: [dpdk-dev] [PATCH 11/21] net/ixgbe/base: modify loop accounting for retries

2020-06-22 Thread Ferruh Yigit
On 6/12/2020 4:24 AM, Guinan Sun wrote: > The condition for comparing retry against max_retry was flawed in the > do-while loops. For the case where retry was initialized to 0 and > max_retry was initialized to 1, we'd break out of the loop at the > condition when the intent is to retry the code a

[dpdk-dev] [PATCH 11/21] net/ixgbe/base: modify loop accounting for retries

2020-06-11 Thread Guinan Sun
The condition for comparing retry against max_retry was flawed in the do-while loops. For the case where retry was initialized to 0 and max_retry was initialized to 1, we'd break out of the loop at the condition when the intent is to retry the code at least once. Otherwise, the loop is unnecessary