Re: [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE header TLV option item

2020-12-30 Thread Shiri Kuzin
an Darawsheh > Subject: RE: [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE > header TLV option item > > > > > -Original Message- > > From: Stephen Hemminger > > > > On Sun, 27 Dec 2020 18:06:16 +0200 > > Shiri Kuzin wrote: >

Re: [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE header TLV option item

2020-12-29 Thread Ori Kam
> -Original Message- > From: Stephen Hemminger > > On Sun, 27 Dec 2020 18:06:16 +0200 > Shiri Kuzin wrote: > > > +#ifdef PEDANTIC > > +#pragma GCC diagnostic ignored "-Wpedantic" > > +#endif > > Please do not introduce pragma's for pedantic in standard headers. > It just clutters th

Re: [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE header TLV option item

2020-12-27 Thread Stephen Hemminger
On Sun, 27 Dec 2020 18:06:16 +0200 Shiri Kuzin wrote: > +#ifdef PEDANTIC > +#pragma GCC diagnostic ignored "-Wpedantic" > +#endif Please do not introduce pragma's for pedantic in standard headers. It just clutters the code unnecessarily. The rest of DPDK is not guaranteed to be free of pedantic

[dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE header TLV option item

2020-12-27 Thread Shiri Kuzin
The Geneve tunneling protocol is designed to allow the user to specify some data context on the packet. The GENEVE TLV (Type-Length-Variable) Option is the mean intended to present the user data. In order to support GENEVE TLV Option the new rte_flow item "rte_flow_item_geneve_opt" is added. The n