Hi Stephen,
On Fri, 17 Mar 2017 09:15:28 -0700, Stephen Hemminger
wrote:
> On Fri, 17 Mar 2017 16:51:15 +0100
> Olivier Matz wrote:
>
> > +static int
> > +rte_log_lookup(const char *name)
> > +{
> > + size_t i;
> > +
> > + for (i = 0; i < rte_logs.dynamic_types_len; i++) {
> > +
On Fri, 17 Mar 2017 16:51:15 +0100
Olivier Matz wrote:
> +static int
> +__rte_log_register(const char *name, int id)
> +{
> + char *dup_name = NULL;
> +
> + dup_name = strdup(name);
Useless initialization!
Many people were taught to always initialize variables. But that was before
compi
On Fri, 17 Mar 2017 16:51:15 +0100
Olivier Matz wrote:
> +static int
> +rte_log_lookup(const char *name)
> +{
> + size_t i;
> +
> + for (i = 0; i < rte_logs.dynamic_types_len; i++) {
> + if (rte_logs.dynamic_types[i].name == NULL)
> + continue;
> +
On Fri, 17 Mar 2017 16:51:15 +0100
Olivier Matz wrote:
> if (type < RTE_LOGTYPE_FIRST_EXT_ID) {
> + if (enable)
> + rte_logs.type |= type;
> + else
> + rte_logs.type &= (~type)
No need for () around ~type
On Fri, 17 Mar 2017 16:51:15 +0100
Olivier Matz wrote:
> + .dynamic_types_len = 0,
> + .dynamic_types = NULL,
> };
>
You don't need to add elements to initializer if the are 0.
Introduce 2 new functions to support dynamic log types:
- rte_log_register(): register a log name, and return a log type id
- rte_log_set_level(): set the log level of a given log type
Signed-off-by: Olivier Matz
---
doc/guides/contributing/coding_style.rst| 30 +++--
lib/librte_eal/bs
6 matches
Mail list logo
