Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-09-30 Thread Ferruh Yigit
On 8/27/2019 9:21 AM, Ferruh Yigit wrote: > On 7/16/2019 4:40 PM, Stephen Hemminger wrote: >> The generic RTE_LOGTYPE_PMD is a historical relic and should >> not be used. Every driver should register the logtypes >> for itself. >> >> Signed-off-by: Stephen Hemminger > > <...> > >> +#ifdef RTE_LI

Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-09-30 Thread Ferruh Yigit
On 9/30/2019 4:50 PM, Stephen Hemminger wrote: > On Mon, 30 Sep 2019 23:28:38 +0800 > Ye Xiaolong wrote: > >> On 08/27, Ferruh Yigit wrote: >>> On 7/16/2019 4:40 PM, Stephen Hemminger wrote: The generic RTE_LOGTYPE_PMD is a historical relic and should not be used. Every driver should

Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-09-30 Thread Stephen Hemminger
On Mon, 30 Sep 2019 23:28:38 +0800 Ye Xiaolong wrote: > On 08/27, Ferruh Yigit wrote: > >On 7/16/2019 4:40 PM, Stephen Hemminger wrote: > >> The generic RTE_LOGTYPE_PMD is a historical relic and should > >> not be used. Every driver should register the logtypes > >> for itself. > >> > >> Signe

Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-09-30 Thread Ye Xiaolong
On 08/27, Ferruh Yigit wrote: >On 7/16/2019 4:40 PM, Stephen Hemminger wrote: >> The generic RTE_LOGTYPE_PMD is a historical relic and should >> not be used. Every driver should register the logtypes >> for itself. >> >> Signed-off-by: Stephen Hemminger > ><...> > >> +#ifdef RTE_LIBRTE_E1000_DEBU

Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-08-27 Thread Ferruh Yigit
On 7/16/2019 4:40 PM, Stephen Hemminger wrote: > The generic RTE_LOGTYPE_PMD is a historical relic and should > not be used. Every driver should register the logtypes > for itself. > > Signed-off-by: Stephen Hemminger <...> > +#ifdef RTE_LIBRTE_E1000_DEBUG_RX > + e1000_logtype_rx = rte_log_

[dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug

2019-07-16 Thread Stephen Hemminger
The generic RTE_LOGTYPE_PMD is a historical relic and should not be used. Every driver should register the logtypes for itself. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/e1000_logs.c | 48 +++--- drivers/net/e1000/e1000_logs.h | 25 +++--- 2 f