Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows

On Sun, 31 May 2020 16:02:21 +0300 Andrew Rybchenko wrote: [snip] > > > > +#ifndef RTE_EXEC_ENV_WINDOWS > > #include > > +#endif > > I really dislike the approach. It adds too many conditional > compilation statements which make code harder to read. > > You can have dummy implementation o

Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows

On Sun, May 31, 2020 at 6:12 PM Fady Bader wrote: > > Tracing is not supported for Windows. > Disabled all trace calls in for Windows. What is the current major issue to enable Trace for windows?. Trace does not need to rte_malloc support, it can work with malloc as well incase rte_malloc is not

Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows

On 5/31/20 3:41 PM, Fady Bader wrote: > Tracing is not supported for Windows. > Disabled all trace calls in for Windows. > > Signed-off-by: Fady Bader > --- > lib/librte_mempool/mempool_trace_points.c | 4 > lib/librte_mempool/rte_mempool.c | 20 > lib/librte_

[dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows

Tracing is not supported for Windows. Disabled all trace calls in for Windows. Signed-off-by: Fady Bader --- lib/librte_mempool/mempool_trace_points.c | 4 lib/librte_mempool/rte_mempool.c | 20 lib/librte_mempool/rte_mempool.h | 22 ++