Re: [dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order Rx

2019-06-19 Thread Tiwei Bie
On Wed, Jun 19, 2019 at 02:34:40PM +0200, Maxime Coquelin wrote: > On 6/18/19 9:41 AM, Tiwei Bie wrote: > > When there is no enough segments for a packet in in-order > > mergeable Rx path, we should free the whole mbuf chain instead > > of just the last segment. > > I would write instead: > > " >

Re: [dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order Rx

2019-06-19 Thread Maxime Coquelin
On 6/18/19 9:41 AM, Tiwei Bie wrote: When there is no enough segments for a packet in in-order mergeable Rx path, we should free the whole mbuf chain instead of just the last segment. I would write instead: " we should free the whole mbuf chain instead of just recycling the last segment.

[dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order Rx

2019-06-18 Thread Tiwei Bie
When there is no enough segments for a packet in in-order mergeable Rx path, we should free the whole mbuf chain instead of just the last segment. Fixes: e5f456a98d3c ("net/virtio: support in-order Rx and Tx") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 2