Re: [dpdk-dev] [PATCH 1/4] net/failsafe: avoid rte_memcpy if rte_realloc fails

2018-11-07 Thread Andrew Rybchenko
On 11/7/18 9:15 PM, Stephen Hemminger wrote: Any solution is fine because of that. You could flag it as false in Coverity or change code to avoid warning. Just want to get it fixed, don't care how. Done, marked it as false positive in Coverity and provided explanation why. Andrew.

Re: [dpdk-dev] [PATCH 1/4] net/failsafe: avoid rte_memcpy if rte_realloc fails

2018-11-07 Thread Stephen Hemminger
On Wed, 7 Nov 2018 09:30:13 +0300 Andrew Rybchenko wrote: > On 11/6/18 10:30 PM, Stephen Hemminger wrote: > > There is a potential issue seen by static tools if number of multicast > > addresses is zero, and rte_realloc of zero size fails (ie returns NULL). > > This won't happen in real world for

Re: [dpdk-dev] [PATCH 1/4] net/failsafe: avoid rte_memcpy if rte_realloc fails

2018-11-06 Thread Andrew Rybchenko
On 11/6/18 10:30 PM, Stephen Hemminger wrote: There is a potential issue seen by static tools if number of multicast addresses is zero, and rte_realloc of zero size fails (ie returns NULL). This won't happen in real world for a couple of reasons: Azure doesn't support multicast (ie this is dead c

[dpdk-dev] [PATCH 1/4] net/failsafe: avoid rte_memcpy if rte_realloc fails

2018-11-06 Thread Stephen Hemminger
There is a potential issue seen by static tools if number of multicast addresses is zero, and rte_realloc of zero size fails (ie returns NULL). This won't happen in real world for a couple of reasons: Azure doesn't support multicast (ie this is dead code); and rte_realloc of zero size will never fa