Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-20 Thread Yang, Zhiyong
Hi, Konstantin: > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, December 16, 2016 7:48 PM > To: Yang, Zhiyong ; Thomas Monjalon > > Cc: dev@dpdk.org; yuanhan@linux.intel.com; Richardson, Bruce > ; De Lara Guarch, Pablo > > Subject: RE:

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-19 Thread Yao, Lei A
> On Fri, Dec 16, 2016 at 10:19:43AM +, Yang, Zhiyong wrote: > > > > I run the same virtio/vhost loopback tests without NIC. > > > > I can see the throughput drop when running choosing functions at run > > > > time compared to original code as following on the same platform(my > > > machine i

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-18 Thread Yuanhan Liu
On Fri, Dec 16, 2016 at 10:19:43AM +, Yang, Zhiyong wrote: > > > I run the same virtio/vhost loopback tests without NIC. > > > I can see the throughput drop when running choosing functions at run > > > time compared to original code as following on the same platform(my > > machine is haswell)

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-16 Thread Ananyev, Konstantin
Hi Zhiyong, > > > > > > > > > > > extern void *(*__rte_memset_vector)( (void *s, int c, size_t n); > > > > > > > > > > static inline void* > > > > > rte_memset_huge(void *s, int c, size_t n) { > > > > >return __rte_memset_vector(s, c, n); } > > > > > > > > > > static inline void * > > > > > rt

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-16 Thread Yang, Zhiyong
ng, Zhiyong > > > Sent: Sunday, December 11, 2016 8:33 PM > > > To: Ananyev, Konstantin ; Thomas > > > Monjalon > > > Cc: dev@dpdk.org; yuanhan....@linux.intel.com; Richardson, Bruce > > > ; De Lara Guarch, Pablo > > > > > &

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-15 Thread Yang, Zhiyong
on > > > > Cc: dev@dpdk.org; yuanhan@linux.intel.com; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Subject: RE: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset > > on IA platform > > > > Hi, Thomas, Konstantin: > > > > &

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-15 Thread Ananyev, Konstantin
PM > > To: Ananyev, Konstantin ; Thomas > > Monjalon > > Cc: dev@dpdk.org; yuanhan@linux.intel.com; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Subject: Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on > > IA platform > >

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-15 Thread Bruce Richardson
; Thomas > > Monjalon > > Cc: dev@dpdk.org; yuanhan@linux.intel.com; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Subject: Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on > > IA platform > > > > Hi, Konstantin, Bruce: &g

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-14 Thread Yang, Zhiyong
> ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on > IA platform > > Hi, Konstantin, Bruce: > > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Thursday, December 8, 2016 6:31 PM > >

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-11 Thread Yang, Zhiyong
dk.org; yuanhan@linux.intel.com; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Subject: RE: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset > > on IA platform > > > > Hi, Konstantin: > > > > > -Original Message

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-11 Thread Yang, Zhiyong
h, Pablo > > Subject: Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on > IA platform > > 2016-12-08 07:41, Yang, Zhiyong: > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > 2016-12-05 16:26, Zhiyong Yang: > > > > +#ifndef _RTE_

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-08 Thread Thomas Monjalon
2016-12-08 07:41, Yang, Zhiyong: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2016-12-05 16:26, Zhiyong Yang: > > > +#ifndef _RTE_MEMSET_X86_64_H_ > > > > Is this implementation specific to 64-bit? > > > > Yes. So should we rename this file? rte_memset.h -> rte_memset_64.h Yo

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-08 Thread Ananyev, Konstantin
dk.org; yuanhan@linux.intel.com; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Subject: RE: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on > > IA platform > > > > > > Hi Zhiyong, > > > > > > > > HI, Thomas:

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-08 Thread Bruce Richardson
g; yuanhan@linux.intel.com; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Subject: RE: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on > > IA platform > > > > > > Hi Zhiyong, > > > > > >

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-08 Thread Yang, Zhiyong
; > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > Sent: Friday, December 2, 2016 6:25 PM > > > To: Yang, Zhiyong > > > Cc: dev@dpdk.org; yuanhan@linux.intel.com; Richardson, Bruce > > > ; Ananyev, Konstantin > > > ; De Lara Guarch, P

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-08 Thread Ananyev, Konstantin
gt; > To: Yang, Zhiyong > > Cc: dev@dpdk.org; yuanhan@linux.intel.com; Richardson, Bruce > > ; Ananyev, Konstantin > > ; De Lara Guarch, Pablo > > > > Subject: Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on > > IA platform > > > &g

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-07 Thread Yang, Zhiyong
linux.intel.com; Richardson, Bruce > ; Ananyev, Konstantin > ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on > IA platform > > 2016-12-05 16:26, Zhiyong Yang: > > +#ifndef _RTE_MEMSET_X86_64_H_ > > Is

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-02 Thread Thomas Monjalon
2016-12-05 16:26, Zhiyong Yang: > +#ifndef _RTE_MEMSET_X86_64_H_ Is this implementation specific to 64-bit? > + > +#define rte_memset memset > + > +#else > + > +static void * > +rte_memset(void *dst, int a, size_t n); > + > +#endif If I understand well, rte_memset (as rte_memcpy) is using the mo

[dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-02 Thread Zhiyong Yang
Performance drop has been caused in some cases when DPDK code calls glibc function memset. reference to discussions about memset in http://dpdk.org/ml/archives/dev/2016-October/048628.html It is necessary to introduce more high efficient function to fix it. One important thing about rte_memset is t