Re: [dpdk-dev] [PATCH 1/3] vhost: fix error path when setting memory tables

2020-11-06 Thread Maxime Coquelin
On 11/6/20 3:53 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, November 5, 2020 7:46 PM >> To: dev@dpdk.org; Ding, Xuan ; >> step...@networkplumber.org; Yigit, Ferruh ; >> tho...@monjalon.net; Xia, Chenbo >> Cc: sta...@dpdk.org;

Re: [dpdk-dev] [PATCH 1/3] vhost: fix error path when setting memory tables

2020-11-05 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, November 5, 2020 7:46 PM > To: dev@dpdk.org; Ding, Xuan ; > step...@networkplumber.org; Yigit, Ferruh ; > tho...@monjalon.net; Xia, Chenbo > Cc: sta...@dpdk.org; Maxime Coquelin > Subject: [PATCH 1/3] vhost: fix e

[dpdk-dev] [PATCH 1/3] vhost: fix error path when setting memory tables

2020-11-05 Thread Maxime Coquelin
If the an error is encountered before the memory regions are parsed, the file descriptors for these shared buffers is leaked. This patch fixes this by closing the message file descriptors on error, taking care of avoiding double closing of the file descriptors. guest_pages is also freed, even thou