Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Tiwei Bie
On Thu, Mar 29, 2018 at 03:41:23PM +0200, Maxime Coquelin wrote: > On 03/29/2018 03:25 PM, Tiwei Bie wrote: > > On Thu, Mar 29, 2018 at 02:19:35PM +0200, Maxime Coquelin wrote: > > > Hi Tiwei, > > > > > > On 03/06/2018 11:43 AM, Tiwei Bie wrote: > > > > Signed-off-by: Tiwei Bie > > > > > > Could

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Maxime Coquelin
On 03/06/2018 11:43 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index 0354740fa..d703d2114 100644 --- a/lib/librte_vhost/socket.c +++ b/l

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Maxime Coquelin
On 03/29/2018 03:25 PM, Tiwei Bie wrote: On Thu, Mar 29, 2018 at 02:19:35PM +0200, Maxime Coquelin wrote: Hi Tiwei, On 03/06/2018 11:43 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie Could you please elaborate a bit more why this is needed? Is it fixing a real issue or just an improvement?

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Tiwei Bie
On Thu, Mar 29, 2018 at 02:19:35PM +0200, Maxime Coquelin wrote: > Hi Tiwei, > > On 03/06/2018 11:43 AM, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > Could you please elaborate a bit more why this is needed? > Is it fixing a real issue or just an improvement? My bad, I really should write

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Maxime Coquelin
Hi Tiwei, On 03/06/2018 11:43 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie Could you please elaborate a bit more why this is needed? Is it fixing a real issue or just an improvement? Thanks! Maxime --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-06 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index 0354740fa..d703d2114 100644 --- a/lib/librte_vhost/socket.c +++ b/lib/librte_vhost/socket.c @@ -181,7 +181,7 @@ se